Skip to content

Commit f2d6185

Browse files
authored
Use optimal flags for the embind_val codesize test (#24615)
- `-sDYNAMIC_EXECUTION=0` was no-op since we added it to common flags. - `-fno-rtti` fallback is actually more expensive than the default RTTI-based mode (using actual `typeid(T)`).
1 parent ce28da1 commit f2d6185

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

test/code_size/embind_val_wasm.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"a.html.gz": 380,
44
"a.js": 5367,
55
"a.js.gz": 2540,
6-
"a.wasm": 9092,
7-
"a.wasm.gz": 4699,
8-
"total": 15011,
9-
"total_gz": 7619
6+
"a.wasm": 7468,
7+
"a.wasm.gz": 3468,
8+
"total": 13387,
9+
"total_gz": 6388
1010
}

test/test_other.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11890,11 +11890,7 @@ def test_minimal_runtime_code_size(self, test_name, wasm2js, compare_js_output=F
1189011890
hello_wasm_worker_sources = [test_file('wasm_worker/wasm_worker_code_size.c'), '-sWASM_WORKERS', '-sENVIRONMENT=web']
1189111891
audio_worklet_sources = [test_file('webaudio/audioworklet.c'), '-sWASM_WORKERS', '-sAUDIO_WORKLET', '-sENVIRONMENT=web', '-sTEXTDECODER=1']
1189211892
embind_hello_sources = [test_file('code_size/embind_hello_world.cpp'), '-lembind']
11893-
embind_val_sources = [test_file('code_size/embind_val_hello_world.cpp'),
11894-
'-lembind',
11895-
'-fno-rtti',
11896-
'-DEMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0',
11897-
'-sDYNAMIC_EXECUTION=0']
11893+
embind_val_sources = [test_file('code_size/embind_val_hello_world.cpp'), '-lembind']
1189811894

1189911895
sources = {
1190011896
'hello_world': hello_world_sources,

0 commit comments

Comments
 (0)