Skip to content

Commit d96d0c2

Browse files
authored
Don't requrie node to run bigint tests. NFC (#18831)
These test should run find under v8
1 parent 21177b5 commit d96d0c2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,6 @@ def metafunc(self, with_bigint):
279279
if self.get_setting('WASM_BIGINT') is not None:
280280
self.skipTest('redundant in bigint test config')
281281
self.set_setting('WASM_BIGINT')
282-
self.require_node()
283282
self.node_args += shared.node_bigint_flags()
284283
f(self)
285284
else:
@@ -467,6 +466,7 @@ def require_node(self):
467466
self.require_engine(config.NODE_JS)
468467

469468
def require_engine(self, engine):
469+
logger.debug(f'require_engine: {engine}')
470470
if self.required_engine and self.required_engine != engine:
471471
self.skipTest(f'Skipping test that requires `{engine}` when `{self.required_engine}` was previously required')
472472
self.required_engine = engine

0 commit comments

Comments
 (0)