Skip to content

Commit d3eaa8d

Browse files
authored
[acorn-optimizer] Remove dummy 'last' pass (#21999)
I'm not sure what this was actually ever used for in the past but is doesn't seem necessary now.
1 parent fb61cb5 commit d3eaa8d

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

test/test_other.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2852,7 +2852,7 @@ def test_js_optimizer_huge(self):
28522852
self.run_process([PYTHON, path_from_root('tools/js_optimizer.py'), 'huge.js', '--minify-whitespace'])
28532853

28542854
@parameterized({
2855-
'wasm2js': ('wasm2js', ['minifyNames', 'last']),
2855+
'wasm2js': ('wasm2js', ['minifyNames']),
28562856
'constructor': ('constructor', ['minifyNames'])
28572857
})
28582858
@crossplatform

tools/acorn-optimizer.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2056,8 +2056,6 @@ const registry = {
20562056
applyImportAndExportNameChanges: applyImportAndExportNameChanges,
20572057
emitDCEGraph: emitDCEGraph,
20582058
applyDCEGraphRemovals: applyDCEGraphRemovals,
2059-
// TODO: remove 'last' in the python driver code
2060-
last: () => {},
20612059
dump: () => dump(ast),
20622060
littleEndianHeap: littleEndianHeap,
20632061
growableHeap: growableHeap,

tools/building.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -933,7 +933,6 @@ def wasm2js(js_file, wasm_file, opt_level, use_closure_compiler, debug_info, sym
933933
passes += ['symbolMap=%s' % symbols_file_js]
934934
if settings.MINIFY_WHITESPACE:
935935
passes += ['--minify-whitespace']
936-
passes += ['last']
937936
if passes:
938937
# hackish fixups to work around wasm2js style and the js optimizer FIXME
939938
wasm2js_js = f'// EMSCRIPTEN_START_ASM\n{wasm2js_js}// EMSCRIPTEN_END_ASM\n'

0 commit comments

Comments
 (0)