Skip to content

Commit bedb50e

Browse files
authored
Disable wasm64 memory growth tests (#19642)
Failure to create TypedArray views (see https://bugs.chromium.org/p/v8/issues/detail?id=4153) causes emscripten's post-memory-growth code to fail in strange ways, so we can't properly test the failure case currently.
1 parent 915b1df commit bedb50e

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

test/test_browser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5506,7 +5506,7 @@ def test_zzz_zzz_2gb_fail(self):
55065506
self.do_run_in_out_file_test('browser', 'test_2GB_fail.cpp')
55075507

55085508
@no_firefox('no 4GB support yet')
5509-
@also_with_wasm64
5509+
# @also_with_wasm64 Blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4153
55105510
@requires_v8
55115511
def test_zzz_zzz_4gb_fail(self):
55125512
# TODO Convert to an actual browser test when it reaches stable.

test/test_other.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6260,10 +6260,9 @@ def test_failing_growth_2gb(self):
62606260
self.assertContained('done', self.run_js('a.out.js'))
62616261

62626262
def test_failing_growth_wasm64(self):
6263-
# For now we don't assert that we can actually grow a memory to over 4Gb because currently
6264-
# this fails under node/d8/chrome with: `WebAssembly.Memory.grow(): Unable to grow instance
6265-
# memory`.
6266-
# See: https://bugs.chromium.org/p/v8/issues/detail?id=4153
6263+
# For now we skip this test because failure to create the TypedArray views
6264+
# causes weird unrecoverable failures.
6265+
self.skipTest('https://bugs.chromium.org/p/v8/issues/detail?id=4153')
62676266
self.require_wasm64()
62686267
create_file('test.c', r'''
62696268
#include <assert.h>

0 commit comments

Comments
 (0)