[acorn-opt] Use parseArgs. NFC (#24496)

Author: RReverser

tools/acorn-optimizer.mjs

@@ -4,6 +4,7 @@ import * as acorn from 'acorn';
 import * as terser from '../third_party/terser/terser.js';
 import * as fs from 'node:fs';
 import assert from 'node:assert';
+import {parseArgs} from 'node:util';
 
 // Utilities
 
@@ -1742,16 +1743,27 @@ function reattachComments(ast, commentsMap) {
 
 let suffix = '';
 
-const argv = process.argv.slice(2);
-
-function getArg(arg) {
-  const index = argv.indexOf(arg);
-  if (index == -1) {
-    return false;
-  }
-  argv.splice(index, 1);
-  return true;
-}
+const {
+  values: {
+    'closure-friendly': closureFriendly,
+    'export-es6': exportES6,
+    verbose,
+    'no-print': noPrint,
+    'minify-whitespace': minifyWhitespace,
+    outfile,
+  },
+  positionals: [infile, ...passes],
+} = parseArgs({
+  options: {
+    'closure-friendly': {type: 'boolean'},
+    'export-es6': {type: 'boolean'},
+    verbose: {type: 'boolean'},
+    'no-print': {type: 'boolean'},
+    'minify-whitespace': {type: 'boolean'},
+    outfile: {type: 'string', short: 'o'},
+  },
+  allowPositionals: true,
+});
 
 function trace(...args) {
   if (verbose) {
@@ -1761,21 +1773,6 @@ function trace(...args) {
 
 // If enabled, output retains parentheses and comments so that the
 // output can further be passed out to Closure.
-const closureFriendly = getArg('--closure-friendly');
-const exportES6 = getArg('--export-es6');
-const verbose = getArg('--verbose');
-const noPrint = getArg('--no-print');
-const minifyWhitespace = getArg('--minify-whitespace');
-
-let outfile;
-const outfileIndex = argv.indexOf('-o');
-if (outfileIndex != -1) {
-  outfile = argv[outfileIndex + 1];
-  argv.splice(outfileIndex, 2);
-}
-
-const infile = argv[0];
-const passes = argv.slice(1);
 
 const input = read(infile);
 const extraInfoStart = input.lastIndexOf('// EXTRA_INFO:');

tools/unsafe_optimizations.mjs

@@ -6,6 +6,7 @@
 import * as fs from 'node:fs';
 import * as acorn from 'acorn';
 import * as terser from '../third_party/terser/terser.js';
+import {parseArgs} from 'node:util';
 
 // Starting at the AST node 'root', calls the given callback function 'func' on all children and grandchildren of 'root'
 // that are of any of the type contained in array 'types'.
@@ -295,38 +296,17 @@ function runTests() {
   process.exit(numTestFailures);
 }
 
-const args = process.argv.slice(2);
-
-function readBool(arg) {
-  let ret = false;
-  for (;;) {
-    const i = args.indexOf(arg);
-    if (i >= 0) {
-      args.splice(i, 1);
-      ret = true;
-    } else {
-      return ret;
-    }
-  }
-}
-
-function readArg(arg) {
-  let ret = null;
-  for (;;) {
-    const i = args.indexOf(arg);
-    if (i >= 0) {
-      ret = args[i + 1];
-      args.splice(i, 2);
-    } else {
-      return ret;
-    }
-  }
-}
-
-const testMode = readBool('--test');
-const pretty = readBool('--pretty');
-const output = readArg('-o');
-const input = args[0];
+const {
+  values: {test: testMode, pretty, output},
+  positionals: [input],
+} = parseArgs({
+  options: {
+    test: {type: 'boolean'},
+    pretty: {type: 'boolean'},
+    output: {type: 'string', short: 'o'},
+  },
+  allowPositionals: true,
+});
 
 if (testMode) {
   runTests();