Skip to content

Commit b1aaca8

Browse files
authored
[WasmFS] Remove ProxiedFileBackend (#18249)
This was an experimental backend for showing that proxying could work. It's not actually useful, though, since backends that require proxying will do their own proxying internally. Since this code isn't useful, remove it to reduce our maintenance burden in future refactorings.
1 parent 3cd47cf commit b1aaca8

File tree

5 files changed

+2
-141
lines changed

5 files changed

+2
-141
lines changed

system/include/emscripten/wasmfs.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ backend_t wasmfs_create_js_file_backend(void);
4040
// A function that receives a void* and returns a backend.
4141
typedef backend_t (*backend_constructor_t)(void*);
4242

43-
// Creates a Proxied Backend in the new file system.
44-
backend_t wasmfs_create_proxied_backend(backend_constructor_t create_backend,
45-
void* arg);
46-
4743
backend_t wasmfs_create_fetch_backend(const char* base_url);
4844

4945
backend_t wasmfs_create_node_backend(const char* root);

system/lib/wasmfs/backends/proxied_file_backend.cpp

Lines changed: 0 additions & 121 deletions
This file was deleted.

test/test_other.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12214,14 +12214,6 @@ def test_wasmfs_jsfile(self):
1221412214
self.set_setting('WASMFS')
1221512215
self.do_run_in_out_file_test('wasmfs/wasmfs_jsfile.c')
1221612216

12217-
@node_pthreads
12218-
def test_wasmfs_jsfile_proxying_backend(self):
12219-
self.emcc_args.append('-DPROXYING')
12220-
self.set_setting('USE_PTHREADS')
12221-
self.set_setting('PROXY_TO_PTHREAD')
12222-
self.set_setting('EXIT_RUNTIME')
12223-
self.test_wasmfs_jsfile()
12224-
1222512217
def test_wasmfs_before_preload(self):
1222612218
self.set_setting('WASMFS')
1222712219
os.mkdir('js_backend_files')

test/wasmfs/wasmfs_jsfile.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,7 @@ static backend_t make_js_file_backend(void* arg) {
3636
}
3737

3838
int main() {
39-
backend_t backend;
40-
#ifndef PROXYING
41-
backend = make_js_file_backend(NULL);
42-
#else
43-
backend = wasmfs_create_proxied_backend(make_js_file_backend, NULL);
44-
#endif
39+
backend_t backend = make_js_file_backend(NULL);
4540

4641
// Create a new backend file under root.
4742
int fd = wasmfs_create_file("/testfile", 0777, backend);

tools/system_libs.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1735,8 +1735,7 @@ def get_files(self):
17351735
'js_file_backend.cpp',
17361736
'memory_backend.cpp',
17371737
'node_backend.cpp',
1738-
'opfs_backend.cpp',
1739-
'proxied_file_backend.cpp'])
1738+
'opfs_backend.cpp'])
17401739
return backends + files_in_path(
17411740
path='system/lib/wasmfs',
17421741
filenames=['file.cpp',

0 commit comments

Comments
 (0)