Skip to content

Commit a80b21a

Browse files
authored
Unpin v8 used in testing. NFC (#18835)
1 parent 53aff41 commit a80b21a

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

.circleci/config.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ executors:
1010
linux-python:
1111
docker:
1212
- image: cimg/python:3.10.7
13-
environment:
14-
# Currently pinned due to https://github.com/emscripten-core/emscripten/issues/17846
15-
V8_VERSION: "10.7.186"
1613
bionic:
1714
docker:
1815
- image: emscripten/emscripten-ci
@@ -23,8 +20,6 @@ executors:
2320
EMTEST_WASI_SYSROOT: "~/wasi-sdk/wasi-sysroot"
2421
EMTEST_BUILD_VERBOSE: "2"
2522
EMTEST_DETECT_TEMPFILE_LEAKS: "1"
26-
# Currently pinned due to https://github.com/emscripten-core/emscripten/issues/17846
27-
V8_VERSION: "10.7.186"
2823
mac:
2924
environment:
3025
EMSDK_NOTTY: "1"
@@ -120,7 +115,7 @@ commands:
120115
tar -xf node-v15.14.0-linux-x64.tar.xz
121116
export PATH="`pwd`/node-v15.14.0-linux-x64/bin:${PATH}"
122117
npm install jsvu -g
123-
jsvu --os=default --engines=v8 v8@${V8_VERSION}
118+
jsvu --os=default --engines=v8
124119
build:
125120
description: "Install emsdk"
126121
steps:
@@ -143,7 +138,7 @@ commands:
143138
# persisted workspace (see below).
144139
echo "CACHE = os.path.expanduser('~/cache')" >> .emscripten
145140
# Refer to commit 0bc3640 if we need to pin V8 version.
146-
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/bin/v8-${V8_VERSION}')]" >> .emscripten
141+
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/bin/v8')]" >> .emscripten
147142
echo "JS_ENGINES = [NODE_JS]" >> .emscripten
148143
echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> .emscripten
149144
echo "WASM_ENGINES = []" >> .emscripten
@@ -726,7 +721,7 @@ jobs:
726721
- run:
727722
name: Remove Linux binaries
728723
command: |
729-
rm -rf ~/emsdk ~/vms
724+
rm -rf ~/emsdk ~/vms ~/.jsvu
730725
- build
731726
# note we do *not* build all libraries and freeze the cache; as we run
732727
# only limited tests here, it's more efficient to build on demand

0 commit comments

Comments
 (0)