Move TARGET_NOT_SUPPORTED to parseTools.js. NFC (#21540)

This is not a setting, its just a constant.

Author: sbc100

src/parseTools.js

@@ -10,6 +10,8 @@
 
 globalThis.FOUR_GB = 4 * 1024 * 1024 * 1024;
 globalThis.WASM_PAGE_SIZE = 64 * 1024;
+// Represents a browser version that is not supported at all.
+globalThis.TARGET_NOT_SUPPORTED = 0x7FFFFFFF;
 
 const FLOAT_TYPES = new Set(['float', 'double']);
 

src/settings_internal.js

@@ -164,9 +164,6 @@ var MINIFY_WASM_IMPORTED_MODULES = false;
 // Whether to minify exports from the Wasm module.
 var MINIFY_WASM_EXPORT_NAMES = true;
 
-// Internal: represents a browser version that is not supported at all.
-var TARGET_NOT_SUPPORTED = 0x7FFFFFFF;
-
 // Used to track whether target environment supports the 'globalThis' attribute.
 var SUPPORTS_GLOBALTHIS = false;
 

tools/minimal_runtime_shell.py

@@ -10,6 +10,7 @@
 from . import shared
 from . import line_endings
 from . import utils
+from . import feature_matrix
 from .settings import settings
 
 logger = logging.getLogger('minimal_runtime_shell')
@@ -23,7 +24,7 @@ def generate_minimal_runtime_load_statement(target_basename):
   # Depending on whether streaming Wasm compilation is enabled or not, the minimal sized code to download Wasm looks a bit different.
   # Expand {{{ DOWNLOAD_WASM }}} block from here (if we added #define support, this could be done in the template directly)
   if settings.MINIMAL_RUNTIME_STREAMING_WASM_COMPILATION:
-    if settings.MIN_SAFARI_VERSION != settings.TARGET_NOT_SUPPORTED or settings.ENVIRONMENT_MAY_BE_NODE or settings.MIN_FIREFOX_VERSION < 58 or settings.MIN_CHROME_VERSION < 61:
+    if settings.MIN_SAFARI_VERSION != feature_matrix.UNSUPPORTED or settings.ENVIRONMENT_MAY_BE_NODE or settings.MIN_FIREFOX_VERSION < 58 or settings.MIN_CHROME_VERSION < 61:
       # Firefox 52 added Wasm support, but only Firefox 58 added compileStreaming.
       # Chrome 57 added Wasm support, but only Chrome 61 added compileStreaming.
       # https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/compileStreaming
@@ -34,7 +35,7 @@ def generate_minimal_runtime_load_statement(target_basename):
       download_wasm = "WebAssembly.compileStreaming(fetch('%s'))" % (target_basename + '.wasm')
   elif settings.MINIMAL_RUNTIME_STREAMING_WASM_INSTANTIATION:
     # Same compatibility story as above for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming
-    if settings.MIN_SAFARI_VERSION != settings.TARGET_NOT_SUPPORTED or settings.ENVIRONMENT_MAY_BE_NODE or settings.MIN_FIREFOX_VERSION < 58 or settings.MIN_CHROME_VERSION < 61:
+    if settings.MIN_SAFARI_VERSION != feature_matrix.UNSUPPORTED or settings.ENVIRONMENT_MAY_BE_NODE or settings.MIN_FIREFOX_VERSION < 58 or settings.MIN_CHROME_VERSION < 61:
       download_wasm = "!WebAssembly.instantiateStreaming && binary('%s')" % (target_basename + '.wasm')
     else:
       # WebAssembly.instantiateStreaming() is unconditionally supported, so we do not download wasm in the .html file,