Skip to content

Commit 9246abf

Browse files
authored
Remove assert on exceptfds, since they are supported (just never happen) (#20105)
1 parent 0112620 commit 9246abf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/library_syscall.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -555,11 +555,11 @@ var SyscallsLibrary = {
555555
__syscall__newselect: (nfds, readfds, writefds, exceptfds, timeout) => {
556556
// readfds are supported,
557557
// writefds checks socket open status
558-
// exceptfds not supported
559-
// timeout is always 0 - fully async
558+
// exceptfds are supported, although on web, such exceptional conditions never arise in web sockets
559+
// and so the exceptfds list will always return empty.
560+
// timeout is supported, although on SOCKFS and PIPEFS these are ignored and always treated as 0 - fully async
560561
#if ASSERTIONS
561562
assert(nfds <= 64, 'nfds must be less than or equal to 64'); // fd sets have 64 bits // TODO: this could be 1024 based on current musl headers
562-
assert(!exceptfds, 'exceptfds not supported');
563563
#endif
564564

565565
var total = 0;

0 commit comments

Comments
 (0)