[Wasm64] Fix argv handling for >4GB memories (#20070)

The old code was using a shift operator to convert pointers to typed
array indexes which does not work for values over 2**32.

Instead we can use the `makeSetValue` helper macros which either use
shifting or division.

Author: sbc100

.circleci/config.yml

@@ -618,6 +618,7 @@ jobs:
             wasm64
             wasm64_4gb.test_hello_world
             wasm64_4gb.test_em_asm
+            wasm64_4gb.test_async_main
             core_2gb.test_em_asm
             wasm64l.test_bigswitch
             other.test_memory64_proxies

emcc.py

@@ -2421,7 +2421,7 @@ def phase_linker_setup(options, state, newargs):
     settings.EXPORT_IF_DEFINED.append('__wasm_apply_data_relocs')
 
   if settings.SIDE_MODULE and 'GLOBAL_BASE' in user_settings:
-    exit_with_error('GLOBAL_BASE is not compatible with SIDE_MODULE')
+    diagnostics.warning('unused-command-line-argument', 'GLOBAL_BASE is not compatible with SIDE_MODULE')
 
   if settings.PROXY_TO_WORKER or options.use_preload_plugins:
     settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$Browser']

src/postamble.js

@@ -74,11 +74,12 @@ function callMain() {
 
   var argc = args.length;
   var argv = stackAlloc((argc + 1) * {{{ POINTER_SIZE }}});
-  var argv_ptr = argv >> {{{ POINTER_SHIFT }}};
+  var argv_ptr = argv;
   args.forEach((arg) => {
-    {{{ POINTER_HEAP }}}[argv_ptr++] = {{{ to64('stringToUTF8OnStack(arg)') }}};
+    {{{ makeSetValue('argv_ptr', 0, 'stringToUTF8OnStack(arg)', '*') }}};
+    argv_ptr += {{{ POINTER_SIZE }}};
   });
-  {{{ POINTER_HEAP }}}[argv_ptr] = {{{ to64('0') }}};
+  {{{ makeSetValue('argv_ptr', 0, 0, '*') }}};
 #else
   var argc = 0;
   var argv = 0;

test/other/metadce/test_metadce_hello_dylink.jssize

@@ -1 +1 @@
-14822
+14820

test/other/metadce/test_metadce_mem_O3.jssize

@@ -1 +1 @@
-5774
+5780

test/other/metadce/test_metadce_mem_O3_grow.jssize

@@ -1 +1 @@
-6094
+6100

test/runner.py

@@ -69,6 +69,7 @@
   'ubsan',
   'wasm64',
   'wasm64_v8',
+  'wasm64_4gb',
 ]
 
 # The default core test mode, used when none is specified