Remove references to RESERVED_FUNCTION_POINTERS. NFC (#19315)

This setting was replaced by ALLOW_TABLE_GROWTH a long time ago.

Author: sbc100

site/source/docs/compiling/WebAssembly.rst

@@ -75,19 +75,6 @@ upgrade from fastcomp to upstream:
   `strip` on an archive file that contains WebAssembly object files it will
   remove the index which makes the archive unusable at link time.
 
-* Fastcomp emits asm.js and so has some limitations on function pointers. For
-  example, the ``RESERVED_FUNCTION_POINTERS`` setting exists there to work
-  around the fact that we can't grow the table. In the upstream backend table
-  growth is easy, and you can just enable ``ALLOW_TABLE_GROWTH``.
-
-* Fastcomp and upstream use very different LLVM and clang versions (fastcomp
-  has been stuck on LLVM 6, upstream is many releases after). This affects
-  optimizations, usually by making the upstream version faster and smaller.
-  However, in rare cases you may see a regression (for example, in some cases
-  *UN*-optimized code may be
-  `less optimal in upstream <https://github.com/emscripten-core/emscripten/issues/10753#issuecomment-603486677>`_,
-  so make sure to optimize both when compiling and when linking).
-
 * Also see the `blocker bugs on the wasm backend <https://github.com/emscripten-core/emscripten/projects/1>`_, and the `wasm backend tagged issues <https://github.com/emscripten-core/emscripten/issues?utf8=✓&q=is%3Aissue+is%3Aopen+label%3A"LLVM+wasm+backend">`_.
 
 Trapping

test/test_core.py

@@ -7410,17 +7410,15 @@ def test_large_exported_response(self):
   def test_add_function(self):
     self.set_setting('INVOKE_RUN', 0)
     self.set_setting('WASM_ASYNC_COMPILATION', 0)
-    self.set_setting('RESERVED_FUNCTION_POINTERS')
+    self.set_setting('ALLOW_TABLE_GROWTH')
     self.set_setting('EXPORTED_RUNTIME_METHODS', ['callMain'])
-    src = test_file('interop/test_add_function.cpp')
-    post_js = test_file('interop/test_add_function_post.js')
-    self.emcc_args += ['--post-js', post_js]
+    self.emcc_args += ['--post-js', test_file('interop/test_add_function_post.js')]
 
     print('basics')
     self.do_run_in_out_file_test('interop/test_add_function.cpp')
 
-    print('with RESERVED_FUNCTION_POINTERS=0')
-    self.set_setting('RESERVED_FUNCTION_POINTERS', 0)
+    print('with ALLOW_TABLE_GROWTH=0')
+    self.set_setting('ALLOW_TABLE_GROWTH', 0)
     expected = 'Unable to grow wasm table'
     if self.is_wasm2js():
       # in wasm2js the error message doesn't come from the VM, but from our
@@ -7429,7 +7427,7 @@ def test_add_function(self):
       # shows a generic error.
       expected = 'wasmTable.grow is not a function'
 
-    self.do_runf(src, expected, assert_returncode=NON_ZERO)
+    self.do_runf(test_file('interop/test_add_function.cpp'), expected, assert_returncode=NON_ZERO)
 
     print('- with table growth')
     self.set_setting('ALLOW_TABLE_GROWTH')
@@ -9573,16 +9571,14 @@ def test_Module_dynamicLibraries_pthreads(self):
 
   # Tests the emscripten_get_exported_function() API.
   def test_emscripten_get_exported_function(self):
-    # Could also test with -sALLOW_TABLE_GROWTH
-    self.set_setting('RESERVED_FUNCTION_POINTERS', 2)
+    self.set_setting('ALLOW_TABLE_GROWTH')
     self.emcc_args += ['-lexports.js']
     self.do_core_test('test_get_exported_function.cpp')
 
   # Tests the emscripten_get_exported_function() API.
   @no_asan('TODO: ASan support in minimal runtime')
   def test_minimal_runtime_emscripten_get_exported_function(self):
-    # Could also test with -sALLOW_TABLE_GROWTH
-    self.set_setting('RESERVED_FUNCTION_POINTERS', 2)
+    self.set_setting('ALLOW_TABLE_GROWTH')
     self.set_setting('MINIMAL_RUNTIME')
     self.emcc_args += ['--pre-js', test_file('minimal_runtime_exit_handling.js')]
     self.emcc_args += ['-lexports.js']