Skip to content

Commit 7cff758

Browse files
authored
Remove expectation of no non-debug custom sections in separate-dwarf files (#22821)
This test is now failing after WebAssembly/binaryen#7043 because the target_features section is in the output binary and gets copied over to the separate-dwarf file (this is because the separate-dwarf file is just a copy of the original file). An alternative to this would be to strip all non-debug custom sections from the side file, although there could be sections that emscripten doesn't know about that it would be desirable to have.
1 parent e817def commit 7cff758

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

test/test_other.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10220,14 +10220,13 @@ def test_separate_dwarf(self):
1022010220
with webassembly.Module('subdir/output.wasm.debug.wasm') as debug_wasm:
1022110221
if not debug_wasm.has_name_section():
1022210222
self.fail('name section not found in separate dwarf file')
10223-
for sec in debug_wasm.sections():
10223+
for _sec in debug_wasm.sections():
1022410224
# TODO(https://github.com/emscripten-core/emscripten/issues/13084):
1022510225
# Re-enable this code once the debugger extension can handle wasm files
1022610226
# with name sections but no code sections.
1022710227
# if sec.type == webassembly.SecType.CODE:
1022810228
# self.fail(f'section of type "{sec.type}" found in separate dwarf file')
10229-
if sec.name and sec.name != 'name' and not sec.name.startswith('.debug'):
10230-
self.fail(f'non-debug section "{sec.name}" found in separate dwarf file')
10229+
pass
1023110230

1023210231
# Check that dwarfdump can dump the debug info
1023310232
dwdump = self.run_process(

0 commit comments

Comments
 (0)