Skip to content

Commit 58e56c4

Browse files
authored
CI: Don't set EMTEST_SKIP_NODE_CANARY when running wasm64 tests. NFC (#20078)
We run this job node canary so there is no need to skip these tests.
1 parent 2e25dd9 commit 58e56c4

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.circleci/config.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -600,15 +600,13 @@ jobs:
600600
# has node canary installed.
601601
test_targets: "wasm64l skip:wasm64l.test_bigswitch"
602602
test-wasm64:
603-
environment:
604-
EMTEST_SKIP_NODE_CANARY: "1"
605603
# We don't use `bionic` here since its tool old to run recent node versions:
606604
# `/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found`
607605
executor: linux-python
608606
steps:
609607
- prepare-for-tests
610608
# The linux-python image uses /home/circleci rather than /root and jsvu
611-
# hardcodes /root into its launcher scripts do we need to reinstall v8.
609+
# hardcodes /root into its launcher scripts so we need to reinstall v8.
612610
- run: rm -rf $HOME/.jsvu
613611
- install-v8
614612
- install-node-canary
@@ -670,7 +668,7 @@ jobs:
670668
- run-tests:
671669
test_targets: "core0.test_hello_world core2.test_demangle_stacks_symbol_map"
672670
test-node-compat:
673-
# We don't use `bionic` here since its tool old to run recent node versions:
671+
# We don't use `bionic` here since its too old to run recent node versions:
674672
# `/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found`
675673
executor: linux-python
676674
environment:

0 commit comments

Comments
 (0)