Remove trivial lambda function wrappers. NFC (#20972)

I found all these using `git grep -P "(\(.*\)) => \w*(\\1)"`.

Author: sbc100

src/library.js

@@ -48,8 +48,8 @@ addToLibrary({
 #if SAFE_HEAP
   // Trivial wrappers around runtime functions that make these symbols available
   // to native code.
-  segfault: () => segfault(),
-  alignfault: () => alignfault(),
+  segfault: '=segfault',
+  alignfault: '=alignfault',
 #endif
 
   // ==========================================================================
@@ -851,7 +851,7 @@ addToLibrary({
 
         return getWeekBasedYear(date).toString().substring(2);
       },
-      '%G': (date) => getWeekBasedYear(date),
+      '%G': getWeekBasedYear,
       '%H': (date) => leadingNulls(date.tm_hour, 2),
       '%I': (date) => {
         var twelveHour = date.tm_hour;
@@ -3032,7 +3032,7 @@ addToLibrary({
   // Converts a JS string to an integer base-10, with signaling error
   // handling (throws a JS exception on error). E.g. jstoi_s("123abc")
   // throws an exception.
-  $jstoi_s: (str) => Number(str),
+  $jstoi_s: 'Number',
 
 #if LINK_AS_CXX
   // libunwind

src/library_async.js

@@ -407,7 +407,7 @@ addToLibrary({
         _free(Asyncify.currData);
         Asyncify.currData = null;
         // Call all sleep callbacks now that the sleep-resume is all done.
-        Asyncify.sleepCallbacks.forEach((func) => callUserCallback(func));
+        Asyncify.sleepCallbacks.forEach(callUserCallback);
       } else {
         abort(`invalid state: ${Asyncify.state}`);
       }
@@ -446,9 +446,7 @@ addToLibrary({
       }
     },
     handleSleep(startAsync) {
-      return Asyncify.handleAsync(() => (
-        new Promise((wakeUp) => startAsync(wakeUp))
-      ));
+      return Asyncify.handleAsync(() => new Promise(startAsync));
     },
     makeAsyncFunction(original) {
 #if ASYNCIFY_DEBUG

src/library_dylink.js

@@ -1006,7 +1006,7 @@ var LibraryDylink = {
       var libFile = locateFile(libName);
       if (flags.loadAsync) {
         return new Promise(function(resolve, reject) {
-          asyncLoad(libFile, (data) => resolve(data), reject);
+          asyncLoad(libFile, resolve, reject);
         });
       }
 

src/library_eventloop.js

@@ -114,7 +114,7 @@ LibraryJSEventLoop = {
   emscripten_set_timeout: (cb, msecs, userData) =>
     safeSetTimeout(() => {{{ makeDynCall('vp', 'cb') }}}(userData), msecs),
 
-  emscripten_clear_timeout: (id) => clearTimeout(id),
+  emscripten_clear_timeout: 'clearTimeout',
 
   emscripten_set_timeout_loop__deps: ['$callUserCallback', 'emscripten_get_now'],
   emscripten_set_timeout_loop: (cb, msecs, userData) => {

src/library_fs_shared.js

@@ -76,7 +76,7 @@ addToLibrary({
     }
     addRunDependency(dep);
     if (typeof url == 'string') {
-      asyncLoad(url, (byteArray) => processData(byteArray), onerror);
+      asyncLoad(url, processData, onerror);
     } else {
       processData(url);
     }

src/library_html5.js

@@ -364,8 +364,7 @@ var LibraryHTML5 = {
 #endif
   },
 #else
-  $findCanvasEventTarget__deps: ['$findEventTarget'],
-  $findCanvasEventTarget: (target) => findEventTarget(target),
+  $findCanvasEventTarget: '$findEventTarget',
 #endif
 
 #else

src/library_pthread.js

@@ -1289,7 +1289,7 @@ var LibraryPThread = {
   _emscripten_notify_mailbox_postmessage__deps: ['$checkMailbox'],
   _emscripten_notify_mailbox_postmessage: (targetThreadId, currThreadId, mainThreadId) => {
     if (targetThreadId == currThreadId) {
-      setTimeout(() => checkMailbox());
+      setTimeout(checkMailbox);
     } else if (ENVIRONMENT_IS_PTHREAD) {
       postMessage({'targetThread' : targetThreadId, 'cmd' : 'checkMailbox'});
     } else {

src/library_sdl.js

@@ -1417,8 +1417,7 @@ var LibrarySDL = {
   // bits-per-pixel of the closest available mode with the given width, height and requested surface flags
   SDL_VideoModeOK: (width, height, depth, flags) => depth, // all modes are ok.
 
-  SDL_AudioDriverName__deps: ['SDL_VideoDriverName'],
-  SDL_AudioDriverName: (buf, max_size) => _SDL_VideoDriverName(buf, max_size),
+  SDL_AudioDriverName: 'SDL_VideoDriverName',
 
   SDL_VideoDriverName__proxy: 'sync',
   SDL_VideoDriverName: (buf, max_size) => {

src/library_webgl2.js

@@ -24,7 +24,7 @@ var LibraryWebGL2 = {
     }
     switch (name) {
       case 0x1F03 /* GL_EXTENSIONS */:
-        var exts = GL.getExtensions().map((e) => stringToNewUTF8(e));
+        var exts = GL.getExtensions().map(stringToNewUTF8);
         stringiCache = GL.stringiCache[name] = exts;
         if (index < 0 || index >= stringiCache.length) {
           GL.recordError(0x501/*GL_INVALID_VALUE*/);

src/proxyWorker.js

@@ -380,7 +380,7 @@ function messageResender() {
   if (calledMain) {
     assert(messageBuffer && messageBuffer.length > 0);
     messageResenderTimeout = null;
-    messageBuffer.forEach((message) => onmessage(message));
+    messageBuffer.forEach(onmessage);
     messageBuffer = null;
   } else {
     messageResenderTimeout = setTimeout(messageResender, 100);