Skip to content

Commit 4aa9164

Browse files
authored
Remove pointless wrapper function in emscripten.py. NFC (#21021)
1 parent 164354f commit 4aa9164

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

tools/emscripten.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -983,7 +983,3 @@ def create_pointer_conversion_wrappers(metadata):
983983
wrappers += 'return wasmExports;\n}'
984984

985985
return wrappers
986-
987-
988-
def run(in_wasm, out_wasm, outfile_js, js_syms, finalize=True):
989-
emscript(in_wasm, out_wasm, outfile_js, js_syms, finalize)

tools/link.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1902,7 +1902,7 @@ def phase_emscript(options, in_wasm, wasm_target, js_syms):
19021902
if shared.SKIP_SUBPROCS:
19031903
return
19041904

1905-
emscripten.run(in_wasm, wasm_target, final_js, js_syms)
1905+
emscripten.emscript(in_wasm, wasm_target, final_js, js_syms)
19061906
save_intermediate('original')
19071907

19081908

@@ -1934,7 +1934,7 @@ def run_embind_gen(wasm_target, js_syms, extra_settings):
19341934
# import names.
19351935
settings.MINIFY_WASM_IMPORTED_MODULES = False
19361936
setup_environment_settings()
1937-
# Use a separate Wasm file so the JS does not need to be modified after emscripten.run.
1937+
# Use a separate Wasm file so the JS does not need to be modified after emscripten.emscript.
19381938
settings.SINGLE_FILE = False
19391939
# Disable support for wasm exceptions
19401940
settings.WASM_EXCEPTIONS = False
@@ -1944,9 +1944,9 @@ def run_embind_gen(wasm_target, js_syms, extra_settings):
19441944
embind_index = settings.JS_LIBRARIES.index('embind/embind.js')
19451945
settings.JS_LIBRARIES[embind_index] = 'embind/embind_gen.js'
19461946
outfile_js = in_temp('tsgen_a.out.js')
1947-
# The Wasm outfile may be modified by emscripten.run, so use a temporary file.
1947+
# The Wasm outfile may be modified by emscripten.emscript, so use a temporary file.
19481948
outfile_wasm = in_temp('tsgen_a.out.wasm')
1949-
emscripten.run(wasm_target, outfile_wasm, outfile_js, js_syms, False)
1949+
emscripten.emscript(wasm_target, outfile_wasm, outfile_js, js_syms, False)
19501950
# Build the flags needed by Node.js to properly run the output file.
19511951
node_args = []
19521952
if settings.MEMORY64:

0 commit comments

Comments
 (0)