Use correct types for syscalls (2)

Author: kleisauke

src/lib/libsigs.js

@@ -230,11 +230,11 @@ sigs = {
   __pthread_create_js__sig: 'ipppp',
   __resumeException__sig: 'vp',
   __syscall__newselect__sig: 'iipppp',
-  __syscall_accept4__sig: 'iippiii',
-  __syscall_bind__sig: 'iippiii',
+  __syscall_accept4__sig: 'iippip',
+  __syscall_bind__sig: 'iipip',
   __syscall_chdir__sig: 'ip',
   __syscall_chmod__sig: 'ipi',
-  __syscall_connect__sig: 'iippiii',
+  __syscall_connect__sig: 'iipip',
   __syscall_dup__sig: 'ii',
   __syscall_dup3__sig: 'iiii',
   __syscall_faccessat__sig: 'iipii',
@@ -252,27 +252,27 @@ sigs = {
   __syscall_ftruncate64__sig: 'iij',
   __syscall_getcwd__sig: 'ipp',
   __syscall_getdents64__sig: 'iipp',
-  __syscall_getpeername__sig: 'iippiii',
-  __syscall_getsockname__sig: 'iippiii',
-  __syscall_getsockopt__sig: 'iiiippi',
+  __syscall_getpeername__sig: 'iippp',
+  __syscall_getsockname__sig: 'iippp',
+  __syscall_getsockopt__sig: 'iiiippp',
   __syscall_ioctl__sig: 'iiip',
-  __syscall_listen__sig: 'iiiiiii',
+  __syscall_listen__sig: 'iiip',
   __syscall_lstat64__sig: 'ipp',
   __syscall_mkdirat__sig: 'iipi',
   __syscall_mknodat__sig: 'iipii',
   __syscall_newfstatat__sig: 'iippi',
   __syscall_openat__sig: 'iipip',
   __syscall_pipe__sig: 'ip',
-  __syscall_poll__sig: 'ipii',
+  __syscall_poll__sig: 'ippi',
   __syscall_readlinkat__sig: 'iippp',
-  __syscall_recvfrom__sig: 'iippipp',
-  __syscall_recvmsg__sig: 'iipiiii',
+  __syscall_recvfrom__sig: 'pippipp',
+  __syscall_recvmsg__sig: 'pipip',
   __syscall_renameat__sig: 'iipip',
   __syscall_rmdir__sig: 'ip',
-  __syscall_sendmsg__sig: 'iipippi',
-  __syscall_sendto__sig: 'iippipp',
-  __syscall_shutdown__sig: 'iiiiiii',
-  __syscall_socket__sig: 'iiiiiii',
+  __syscall_sendmsg__sig: 'pipip',
+  __syscall_sendto__sig: 'pippipi',
+  __syscall_shutdown__sig: 'iiip',
+  __syscall_socket__sig: 'iiiip',
   __syscall_stat64__sig: 'ipp',
   __syscall_statfs64__sig: 'ippp',
   __syscall_symlinkat__sig: 'ipip',

src/lib/libsyscall.js

@@ -345,15 +345,15 @@ var SyscallsLibrary = {
     return info;
   },
   __syscall_socket__deps: ['$SOCKFS'],
-  __syscall_socket: (domain, type, protocol) => {
+  __syscall_socket: (domain, type, protocol, varargs) => {
     var sock = SOCKFS.createSocket(domain, type, protocol);
 #if ASSERTIONS
     assert(sock.stream.fd < 64); // XXX ? select() assumes socket fd values are in 0..63
 #endif
     return sock.stream.fd;
   },
   __syscall_getsockname__deps: ['$getSocketFromFD', '$writeSockaddr', '$DNS'],
-  __syscall_getsockname: (fd, addr, addrlen, d1, d2, d3) => {
+  __syscall_getsockname: (fd, addr, addrlen, varargs) => {
     var sock = getSocketFromFD(fd);
     // TODO: sock.saddr should never be undefined, see TODO in websocket_sock_ops.getname
     var errno = writeSockaddr(addr, sock.family, DNS.lookup_name(sock.saddr || '0.0.0.0'), sock.sport, addrlen);
@@ -363,7 +363,7 @@ var SyscallsLibrary = {
     return 0;
   },
   __syscall_getpeername__deps: ['$getSocketFromFD', '$writeSockaddr', '$DNS'],
-  __syscall_getpeername: (fd, addr, addrlen, d1, d2, d3) => {
+  __syscall_getpeername: (fd, addr, addrlen, varargs) => {
     var sock = getSocketFromFD(fd);
     if (!sock.daddr) {
       return -{{{ cDefs.ENOTCONN }}}; // The socket is not connected.
@@ -375,19 +375,19 @@ var SyscallsLibrary = {
     return 0;
   },
   __syscall_connect__deps: ['$getSocketFromFD', '$getSocketAddress'],
-  __syscall_connect: (fd, addr, addrlen, d1, d2, d3) => {
+  __syscall_connect: (fd, addr, addrlen, varargs) => {
     var sock = getSocketFromFD(fd);
     var info = getSocketAddress(addr, addrlen);
     sock.sock_ops.connect(sock, info.addr, info.port);
     return 0;
   },
   __syscall_shutdown__deps: ['$getSocketFromFD'],
-  __syscall_shutdown: (fd, how) => {
+  __syscall_shutdown: (fd, how, varargs) => {
     getSocketFromFD(fd);
     return -{{{ cDefs.ENOSYS }}}; // unsupported feature
   },
   __syscall_accept4__deps: ['$getSocketFromFD', '$writeSockaddr', '$DNS'],
-  __syscall_accept4: (fd, addr, addrlen, flags, d1, d2) => {
+  __syscall_accept4: (fd, addr, addrlen, flags, varargs) => {
     var sock = getSocketFromFD(fd);
     var newsock = sock.sock_ops.accept(sock);
     if (addr) {
@@ -399,14 +399,14 @@ var SyscallsLibrary = {
     return newsock.stream.fd;
   },
   __syscall_bind__deps: ['$getSocketFromFD', '$getSocketAddress'],
-  __syscall_bind: (fd, addr, addrlen, d1, d2, d3) => {
+  __syscall_bind: (fd, addr, addrlen, varargs) => {
     var sock = getSocketFromFD(fd);
     var info = getSocketAddress(addr, addrlen);
     sock.sock_ops.bind(sock, info.addr, info.port);
     return 0;
   },
   __syscall_listen__deps: ['$getSocketFromFD'],
-  __syscall_listen: (fd, backlog) => {
+  __syscall_listen: (fd, backlog, varargs) => {
     var sock = getSocketFromFD(fd);
     sock.sock_ops.listen(sock, backlog);
     return 0;
@@ -437,7 +437,7 @@ var SyscallsLibrary = {
     return sock.sock_ops.sendmsg(sock, HEAP8, message, length, dest.addr, dest.port);
   },
   __syscall_getsockopt__deps: ['$getSocketFromFD'],
-  __syscall_getsockopt: (fd, level, optname, optval, optlen, d1) => {
+  __syscall_getsockopt: (fd, level, optname, optval, optlen, varargs) => {
     var sock = getSocketFromFD(fd);
     // Minimal getsockopt aimed at resolving https://github.com/emscripten-core/emscripten/issues/2211
     // so only supports SOL_SOCKET with SO_ERROR.
@@ -452,7 +452,7 @@ var SyscallsLibrary = {
     return -{{{ cDefs.ENOPROTOOPT }}}; // The option is unknown at the level indicated.
   },
   __syscall_sendmsg__deps: ['$getSocketFromFD', '$getSocketAddress'],
-  __syscall_sendmsg: (fd, message, flags, d1, d2, d3) => {
+  __syscall_sendmsg: (fd, message, flags, varargs) => {
     var sock = getSocketFromFD(fd);
     var iov = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iov, '*') }}};
     var num = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iovlen, 'i32') }}};
@@ -483,7 +483,7 @@ var SyscallsLibrary = {
     return sock.sock_ops.sendmsg(sock, view, 0, total, addr, port);
   },
   __syscall_recvmsg__deps: ['$getSocketFromFD', '$writeSockaddr', '$DNS'],
-  __syscall_recvmsg: (fd, message, flags, d1, d2, d3) => {
+  __syscall_recvmsg: (fd, message, flags, varargs) => {
     var sock = getSocketFromFD(fd);
     var iov = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iov, '*') }}};
     var num = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iovlen, 'i32') }}};

system/lib/libc/emscripten_internal.h

@@ -76,9 +76,9 @@ int _mmap_js(size_t length,
              int* allocated,
              void** addr);
 int _munmap_js(
-  intptr_t addr, size_t length, int prot, int flags, int fd, off_t offset);
+  void *addr, size_t length, int prot, int flags, int fd, off_t offset);
 int _msync_js(
-  intptr_t addr, size_t length, int prot, int flags, int fd, off_t offset);
+  void *addr, size_t length, int prot, int flags, int fd, off_t offset);
 
 struct dso;
 

system/lib/libc/emscripten_mmap.c

@@ -35,10 +35,10 @@ struct map {
 static volatile int lock[1];
 static struct map* mappings;
 
-static struct map* find_mapping(intptr_t addr, struct map** prev) {
+static struct map* find_mapping(void *addr, struct map** prev) {
   struct map* map = mappings;
   while (map) {
-    if (map->addr == (void*)addr) {
+    if (map->addr == addr) {
       return map;
     }
     if (prev) {
@@ -49,7 +49,7 @@ static struct map* find_mapping(intptr_t addr, struct map** prev) {
   return map;
 }
 
-int __syscall_munmap(intptr_t addr, size_t length) {
+int __syscall_munmap(void *addr, size_t length) {
   LOCK(lock);
   struct map* prev = NULL;
   struct map* map = find_mapping(addr, &prev);
@@ -89,7 +89,7 @@ int __syscall_munmap(intptr_t addr, size_t length) {
   return 0;
 }
 
-int __syscall_msync(intptr_t addr, size_t len, int flags) {
+int __syscall_msync(void *addr, size_t len, int flags) {
   LOCK(lock);
   struct map* map = find_mapping(addr, NULL);
   UNLOCK(lock);
@@ -102,7 +102,7 @@ int __syscall_msync(intptr_t addr, size_t len, int flags) {
   return _msync_js(addr, len, map->prot, map->flags, map->fd, map->offset);
 }
 
-intptr_t __syscall_mmap2(intptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) {
+intptr_t __syscall_mmap2(void *addr, size_t len, int prot, int flags, int fd, off_t offset) {
   if (addr != 0) {
     // We don't currently support location hints for the address of the mapping
     return -EINVAL;

system/lib/libc/emscripten_syscall_stubs.c

@@ -47,7 +47,7 @@ static mode_t g_umask = S_IWGRP | S_IWOTH;
 #define STRINGIFY(s) #s
 #define STR(s) STRINGIFY(s)
 
-weak int __syscall_uname(intptr_t buf) {
+weak int __syscall_uname(void *buf) {
   if (!buf) {
     return -EFAULT;
   }
@@ -105,15 +105,15 @@ weak pid_t __syscall_getppid() {
   return g_ppid;
 }
 
-weak int __syscall_linkat(int olddirfd, intptr_t oldpath, int newdirfd, intptr_t newpath, int flags) {
+weak int __syscall_linkat(int olddirfd, const char *oldpath, int newdirfd, const char *newpath, int flags) {
   return -EMLINK; // no hardlinks for us
 }
 
-weak int __syscall_getgroups32(int count, intptr_t list) {
+weak int __syscall_getgroups32(int count, gid_t list[]) {
   if (count < 1) {
     return -EINVAL;
   }
-  ((gid_t*)list)[0] = 0;
+  list[0] = 0;
   return 1;
 }
 
@@ -127,7 +127,7 @@ weak mode_t __syscall_umask(mode_t mask) {
   return old;
 }
 
-weak int __syscall_getrusage(int who, intptr_t usage) {
+weak int __syscall_getrusage(int who, void *usage) {
   REPORT(getrusage);
   struct rusage *u = (struct rusage *)usage;
   memset(u, 0, sizeof(*u));
@@ -146,7 +146,7 @@ weak int __syscall_setpriority(int which, id_t who, int prio) {
   return -EPERM;
 }
 
-weak int __syscall_setdomainname(intptr_t name, size_t size) {
+weak int __syscall_setdomainname(const char *name, size_t len) {
   return -EPERM;
 }
 
@@ -166,18 +166,18 @@ weak gid_t __syscall_getegid32(void) {
   return 0;
 }
 
-weak int __syscall_getresuid32(intptr_t ruid, intptr_t euid, intptr_t suid) {
-  *((uid_t *)ruid) = 0;
-  *((uid_t *)euid) = 0;
-  *((uid_t *)suid) = 0;
+weak int __syscall_getresuid32(uid_t *ruid, uid_t *euid, uid_t *suid) {
+  *ruid = 0;
+  *euid = 0;
+  *suid = 0;
   return 0;
 }
 
-weak int __syscall_getresgid32(intptr_t ruid, intptr_t euid, intptr_t suid) {
+weak int __syscall_getresgid32(gid_t *rgid, gid_t *egid, gid_t *sgid) {
   REPORT(getresgid32);
-  *((uid_t *)ruid) = 0;
-  *((uid_t *)euid) = 0;
-  *((uid_t *)suid) = 0;
+  *rgid = 0;
+  *egid = 0;
+  *sgid = 0;
   return 0;
 }
 
@@ -186,28 +186,28 @@ weak int __syscall_pause() {
   return -EINTR; // we can't pause
 }
 
-weak int __syscall_madvise(intptr_t addr, size_t length, int advice) {
+weak int __syscall_madvise(void *addr, size_t length, int advice) {
   REPORT(madvise);
   // advice is welcome, but ignored
   return 0;
 }
 
-weak int __syscall_mlock(intptr_t addr, size_t len) {
+weak int __syscall_mlock(const void *addr, size_t len) {
   REPORT(mlock);
   return 0;
 }
 
-weak int __syscall_munlock(intptr_t addr, size_t len) {
+weak int __syscall_munlock(const void *addr, size_t len) {
   REPORT(munlock);
   return 0;
 }
 
-weak int __syscall_mprotect(size_t addr, size_t len, int prot) {
+weak int __syscall_mprotect(size_t start, size_t len, int prot) {
   REPORT(mprotect);
   return 0; // let's not and say we did
 }
 
-weak int __syscall_mremap(intptr_t old_addr, size_t old_size, size_t new_size, int flags, intptr_t new_addr) {
+weak int __syscall_mremap(void *old_addr, size_t old_size, size_t new_size, int flags, void *new_addr) {
   REPORT(mremap);
   return -ENOMEM; // never succeed
 }
@@ -222,7 +222,7 @@ weak int __syscall_munlockall() {
   return 0;
 }
 
-weak int __syscall_prlimit64(pid_t pid, int resource, intptr_t new_limit, intptr_t old_limit) {
+weak int __syscall_prlimit64(pid_t pid, int resource, const void *new_limit, void *old_limit) {
   REPORT(prlimit64);
   struct rlimit *old = (struct rlimit *)old_limit;
   if (new_limit) {
@@ -249,17 +249,18 @@ weak int __syscall_prlimit64(pid_t pid, int resource, intptr_t new_limit, intptr
   return 0;
 }
 
-weak int __syscall_setsockopt(int sockfd, int level, int optname, intptr_t optval, size_t optlen, int dummy) {
+weak int __syscall_setsockopt(int sockfd, int level, int optname, const void *optval, socklen_t optlen, ...) {
   REPORT(setsockopt);
   return -ENOPROTOOPT; // The option is unknown at the level indicated.
 }
 
-UNIMPLEMENTED(acct, (intptr_t filename))
-UNIMPLEMENTED(mincore, (intptr_t addr, size_t length, intptr_t vec))
-UNIMPLEMENTED(pipe2, (intptr_t fds, int flags))
-UNIMPLEMENTED(pselect6, (int nfds, intptr_t readfds, intptr_t writefds, intptr_t exceptfds, intptr_t timeout, intptr_t sigmaks))
-UNIMPLEMENTED(recvmmsg, (int sockfd, intptr_t msgvec, size_t vlen, int flags, ...))
-UNIMPLEMENTED(sendmmsg, (int sockfd, intptr_t msgvec, size_t vlen, int flags, ...))
-UNIMPLEMENTED(shutdown, (int sockfd, int how, int dummy, int dummy2, int dummy3, int dummy4))
-UNIMPLEMENTED(socketpair, (int domain, int type, int protocol, intptr_t fds, int dummy, int dummy2))
-UNIMPLEMENTED(wait4,(pid_t pid, intptr_t wstatus, int options, int rusage))
+UNIMPLEMENTED(acct, (const char *filename))
+UNIMPLEMENTED(mincore, (void *addr, size_t length, unsigned char *vec))
+UNIMPLEMENTED(pipe2, (int pipefd[2], int flags))
+UNIMPLEMENTED(pselect6, (int nfds, void *rfds, void *wfds, void *efds, void *ts, const void *mask))
+UNIMPLEMENTED(recvmmsg, (int sockfd, void *msgvec, unsigned int vlen, int flags, struct timespec *timeout))
+UNIMPLEMENTED(sendmmsg, (int sockfd, void *msgvec, unsigned int vlen, int flags))
+UNIMPLEMENTED(shutdown, (int sockfd, int how, ...))
+UNIMPLEMENTED(socketpair, (int domain, int type, int protocol, int fd[2], ...))
+UNIMPLEMENTED(socketcall, (int call, long args[6]))
+UNIMPLEMENTED(wait4, (pid_t pid, int *wstatus, int options, void *rusage))