Skip to content

Commit 4881eaf

Browse files
authored
Re-enable poppler test. NFC (#17174)
Fixes: #14614
1 parent 648022d commit 4881eaf

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

emcc.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,10 @@ def check_human_readable_list(items):
602602

603603
def make_js_executable(script):
604604
src = read_file(script)
605-
cmd = shared.shlex_join(config.JS_ENGINE)
605+
cmd = config.JS_ENGINE
606+
if settings.WASM_BIGINT:
607+
cmd.append('--experimental-wasm-bigint')
608+
cmd = shared.shlex_join(cmd)
606609
if not os.path.isabs(config.JS_ENGINE[0]):
607610
# TODO: use whereis etc. And how about non-*NIX?
608611
cmd = '/usr/bin/env -S ' + cmd

tests/test_core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6776,9 +6776,9 @@ def test_bullet(self, use_cmake):
67766776
libraries=self.get_bullet_library(use_cmake),
67776777
includes=[test_file('third_party/bullet/src')])
67786778

6779-
@unittest.skip('LLVM changes have caused this C++ to no longer compile, https://github.com/emscripten-core/emscripten/issues/14614')
67806779
@no_asan('issues with freetype itself')
67816780
@needs_make('depends on freetype')
6781+
@no_wasm64('MEMORY64 does not yet support SJLJ')
67826782
@is_slow_test
67836783
def test_poppler(self):
67846784
pdf_data = read_binary(test_file('poppler/paper.pdf'))

0 commit comments

Comments
 (0)