Factor out FS.getStreamChecked. NFC (#19529)

Author: sbc100

src/library_fs.js

@@ -381,6 +381,13 @@ FS.staticInit();` +
       }
       throw new FS.ErrnoError({{{ cDefs.EMFILE }}});
     },
+    getStreamChecked: (fd) => {
+      var stream = FS.getStream(fd);
+      if (!stream) {
+        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
+      }
+      return stream;
+    },
     getStream: (fd) => FS.streams[fd],
     // TODO parameterize this function such that a stream
     // object isn't directly passed in. not possible until
@@ -911,10 +918,7 @@ FS.staticInit();` +
       FS.chmod(path, mode, true);
     },
     fchmod: (fd, mode) => {
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       FS.chmod(stream.node, mode);
     },
     chown: (path, uid, gid, dontFollow) => {
@@ -937,10 +941,7 @@ FS.staticInit();` +
       FS.chown(path, uid, gid, true);
     },
     fchown: (fd, uid, gid) => {
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       FS.chown(stream.node, uid, gid);
     },
     truncate: (path, len) => {
@@ -973,10 +974,7 @@ FS.staticInit();` +
       });
     },
     ftruncate: (fd, len) => {
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       if ((stream.flags & {{{ cDefs.O_ACCMODE }}}) === {{{ cDefs.O_RDONLY}}}) {
         throw new FS.ErrnoError({{{ cDefs.EINVAL }}});
       }
@@ -1361,8 +1359,7 @@ FS.staticInit();` +
           node.node_ops = {
             lookup: (parent, name) => {
               var fd = +name;
-              var stream = FS.getStream(fd);
-              if (!stream) throw new FS.ErrnoError({{{ cDefs.EBADF }}});
+              var stream = FS.getStreamChecked(fd);
               var ret = {
                 parent: null,
                 mount: { mountpoint: 'fake' },

src/library_noderawfs.js

@@ -70,18 +70,12 @@ mergeInto(LibraryManager.library, {
     lstat: function() { return fs.lstatSync.apply(void 0, arguments); },
     chmod: function() { fs.chmodSync.apply(void 0, arguments); },
     fchmod: function(fd, mode) {
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       fs.fchmodSync(stream.nfd, mode);
     },
     chown: function() { fs.chownSync.apply(void 0, arguments); },
     fchown: function(fd, owner, group) {
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       fs.fchownSync(stream.nfd, owner, group);
     },
     truncate: function() { fs.truncateSync.apply(void 0, arguments); },
@@ -90,10 +84,7 @@ mergeInto(LibraryManager.library, {
       if (len < 0) {
         throw new FS.ErrnoError({{{ cDefs.EINVAL }}});
       }
-      var stream = FS.getStream(fd);
-      if (!stream) {
-        throw new FS.ErrnoError({{{ cDefs.EBADF }}});
-      }
+      var stream = FS.getStreamChecked(fd);
       fs.ftruncateSync(stream.nfd, len);
     },
     utime: function(path, atime, mtime) { fs.utimesSync(path, atime/1000, mtime/1000); },

src/library_syscall.js

@@ -114,8 +114,7 @@ var SyscallsLibrary = {
 #if SYSCALLS_REQUIRE_FILESYSTEM
     // Just like `FS.getStream` but will throw EBADF if stream is undefined.
     getStreamFromFD: function(fd) {
-      var stream = FS.getStream(fd);
-      if (!stream) throw new FS.ErrnoError({{{ cDefs.EBADF }}});
+      var stream = FS.getStreamChecked(fd);
 #if SYSCALL_DEBUG
       dbg(`    (stream: "${stream.path}")`);
 #endif

test/other/metadce/test_metadce_cxx_ctors1.jssize

@@ -1 +1 @@
-25951
+25923

test/other/metadce/test_metadce_cxx_ctors2.jssize

@@ -1 +1 @@
-25915
+25887

test/other/metadce/test_metadce_cxx_except.jssize

@@ -1 +1 @@
-30465
+30437

test/other/metadce/test_metadce_cxx_except_wasm.jssize

@@ -1 +1 @@
-25760
+25732

test/other/metadce/test_metadce_cxx_mangle.jssize

@@ -1 +1 @@
-30464
+30436

test/other/metadce/test_metadce_cxx_noexcept.jssize

@@ -1 +1 @@
-25951
+25923

test/other/metadce/test_metadce_files_js_fs.jssize

@@ -1 +1 @@
-20273
+20245