Skip to content

Commit 38d1292

Browse files
authored
Remove source-map dependency from terser bundle (#17067)
When updating terser to 4.1.0 in #17035 I inadvertently introduced a dependency on the node source-map module. Rebuilding after patching our terser fork removed this: emscripten-core/terser@b3ace3b This happens to be available during testing because it one of our dev decpendencies but we not include it in our end-user/production dependencies. This kind of error is hard to find since the `node_modules` for our test setup is the same as the node_modules for emscripten itself. It migth be worth attempting to tease them appart if this kind of thing ever shows up again.
1 parent d0090ea commit 38d1292

File tree

2 files changed

+2402
-2787
lines changed

2 files changed

+2402
-2787
lines changed

third_party/terser/README.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,5 @@ To make changes to this code please submit patches to
1313
https://github.com/emscripten-core/terser/ and then re-create this bundle
1414
using the following steps:
1515

16-
$ CI=1 npm run build
17-
$ cp dist/bundle.min.js $EMSCRIPTEN_ROOT/third_party/terser/terser.js
18-
19-
Despite its name, `dist/bundle.min.js` should not be minified (due to the `CI=1`
20-
in the command avove).
16+
$ npx rollup -c
17+
$ cp dist/bundle.js $EMSCRIPTEN_ROOT/third_party/terser/terser.js

0 commit comments

Comments
 (0)