Skip to content

Commit 324224f

Browse files
authored
WasmFS JS API: Clean up API Wrappers (#19605)
This PR removes the unnecessary if statements in the JS API, since the syscalls do not actually set errno. This PR does not change any functionality of the API wrapper methods.
1 parent 23fab93 commit 324224f

File tree

1 file changed

+5
-25
lines changed

1 file changed

+5
-25
lines changed

system/lib/wasmfs/js_api.cpp

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,11 @@ int _wasmfs_mkdir(char* path, int mode) {
126126
int _wasmfs_rmdir(char* path){ return __syscall_unlinkat(AT_FDCWD, (intptr_t)path, AT_REMOVEDIR); }
127127

128128
int _wasmfs_open(char* path, int flags, mode_t mode) {
129-
int err = __syscall_openat(AT_FDCWD, (intptr_t)path, flags, mode);
130-
if (err == -1) {
131-
return -errno;
132-
}
133-
return err;
129+
return __syscall_openat(AT_FDCWD, (intptr_t)path, flags, mode);
134130
}
135131

136132
int _wasmfs_mknod(char* path, mode_t mode, dev_t dev) {
137-
int err = __syscall_mknodat(AT_FDCWD, (intptr_t)path, mode, dev);
138-
if (err == -1) {
139-
return errno;
140-
}
141-
return err;
133+
return __syscall_mknodat(AT_FDCWD, (intptr_t)path, mode, dev);
142134
}
143135

144136
int _wasmfs_unlink(char* path) {
@@ -190,11 +182,7 @@ int _wasmfs_lchmod(char* path, mode_t mode) {
190182
}
191183

192184
int _wasmfs_rename(char* oldpath, char* newpath) {
193-
int err = __syscall_renameat(AT_FDCWD, (intptr_t)oldpath, AT_FDCWD, (intptr_t)newpath);
194-
if (err == -1) {
195-
return errno;
196-
}
197-
return err;
185+
return __syscall_renameat(AT_FDCWD, (intptr_t)oldpath, AT_FDCWD, (intptr_t)newpath);
198186
};
199187

200188
int _wasmfs_read(int fd, void *buf, size_t count) {
@@ -228,19 +216,11 @@ int _wasmfs_close(int fd) {
228216
}
229217

230218
int _wasmfs_stat(char* path, struct stat* statBuf) {
231-
int err = __syscall_stat64((intptr_t)path, (intptr_t)statBuf);
232-
if (err == -1) {
233-
return errno;
234-
}
235-
return err;
219+
return __syscall_stat64((intptr_t)path, (intptr_t)statBuf);
236220
}
237221

238222
int _wasmfs_lstat(char* path, struct stat* statBuf) {
239-
int err = __syscall_lstat64((intptr_t)path, (intptr_t)statBuf);
240-
if (err == -1) {
241-
return errno;
242-
}
243-
return err;
223+
return __syscall_lstat64((intptr_t)path, (intptr_t)statBuf);
244224
}
245225

246226
// Helper method that identifies what a path is:

0 commit comments

Comments
 (0)