Skip to content

Commit 319b423

Browse files
authored
Use simple response file format in test code. NFC (#22976)
The simple one-line-per-element format is recommended these days. We have other tests that actually test both formats work (`test_dash_s_list_parsing` and `test_dash_s_response_file_list`)
1 parent 1b15088 commit 319b423

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/test_core.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7155,7 +7155,7 @@ def test_exported_response(self):
71557155
return 0;
71567156
}
71577157
'''
7158-
create_file('exps', '["_main","_other_function"]')
7158+
create_file('exps', '_main\n_other_function\n')
71597159

71607160
self.set_setting('EXPORTED_FUNCTIONS', '@exps')
71617161
self.do_run(src, '''waka 5!''')
@@ -7170,12 +7170,12 @@ def test_large_exported_response(self):
71707170
extern "C" {
71717171
'''
71727172

7173-
js_funcs = []
7173+
rsp_file_lines = []
71747174
num_exports = 5000
71757175
count = 0
71767176
while count < num_exports:
71777177
src += 'int exported_func_from_response_file_%d () { return %d;}\n' % (count, count)
7178-
js_funcs.append('_exported_func_from_response_file_%d' % count)
7178+
rsp_file_lines.append('_exported_func_from_response_file_%d' % count)
71797179
count += 1
71807180

71817181
src += r'''
@@ -7191,8 +7191,8 @@ def test_large_exported_response(self):
71917191
}
71927192
'''
71937193

7194-
js_funcs.append('_main')
7195-
create_file('large_exported_response.json', json.dumps(js_funcs))
7194+
rsp_file_lines.append('_main')
7195+
create_file('large_exported_response.json', '\n'.join(rsp_file_lines) + '\n')
71967196

71977197
self.set_setting('EXPORTED_FUNCTIONS', '@large_exported_response.json')
71987198
self.do_run(src, 'waka 4999!')
@@ -8193,8 +8193,8 @@ def test_asyncify_unused(self):
81938193
'onlylist_b': (['-sASYNCIFY_ONLY=["main","__original_main","foo(int, double)","baz()","c_baz","Structy::funcy()"]'], True),
81948194
'onlylist_c': (['-sASYNCIFY_ONLY=["main","__original_main","foo(int, double)","baz()","c_baz"]'], False),
81958195
'onlylist_d': (['-sASYNCIFY_ONLY=["foo(int, double)","baz()","c_baz","Structy::funcy()"]'], False),
8196-
'onlylist_b_response': ([], True, '["main","__original_main","foo(int, double)","baz()","c_baz","Structy::funcy()"]'),
8197-
'onlylist_c_response': ([], False, '["main","__original_main","foo(int, double)","baz()","c_baz"]'),
8196+
'onlylist_b_response': ([], True, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\nStructy::funcy()\n'),
8197+
'onlylist_c_response': ([], False, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\n'),
81988198
})
81998199
def test_asyncify_lists(self, args, should_pass, response=None):
82008200
if response is not None:

0 commit comments

Comments
 (0)