Skip to content

Commit 24e6313

Browse files
authored
Fix macos-arm64 CI. NFC (#19658)
We were previously using EMTEST_SKIP_SIMD to skip simd tests due to lack of native clang, but since we updated node to v16 `EMTEST_SKIP_SIMD` is not even checked. Instead use `EMTEST_LACKS_NATIVE_CLANG` to skip the tests that depend on this.
1 parent daeb866 commit 24e6313

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,6 @@ jobs:
723723
EMTEST_SKIP_V8: "1"
724724
EMTEST_SKIP_EH: "1"
725725
EMTEST_SKIP_WASM64: "1"
726-
EMTEST_SKIP_SIMD: "1"
727726
EMTEST_SKIP_SCONS: "1"
728727
EMCC_SKIP_SANITY_CHECK: "1"
729728
steps:
@@ -752,8 +751,9 @@ jobs:
752751
EMTEST_SKIP_V8: "1"
753752
EMTEST_SKIP_EH: "1"
754753
EMTEST_SKIP_WASM64: "1"
755-
EMTEST_SKIP_SIMD: "1"
756754
EMTEST_SKIP_SCONS: "1"
755+
# Some native clang tests assume x86 clang (e.g. -sse2)
756+
EMTEST_LACKS_NATIVE_CLANG: "1"
757757
EMCC_SKIP_SANITY_CHECK: "1"
758758
steps:
759759
- setup-macos

0 commit comments

Comments
 (0)