Simplify embind $new_ helper. NFC (#19109)

This function is only needed when DYNAMIC_EXECUTION is defined.  Its
also only got two callsites that both pass `Function` as arg0.

I guess maybe this function previously had more callers that could
explain why it seems to general but I looked back as far as the big
refactor in 2014 (350f199) and I couldn't find anything.

I think this is can be even further simplified but this is a good first
step.

Author: sbc100

src/embind/embind.js

@@ -18,7 +18,7 @@
 /*global simpleReadValueFromPointer, floatReadValueFromPointer, integerReadValueFromPointer, enumReadValueFromPointer, replacePublicSymbol, craftInvokerFunction, tupleRegistrations*/
 /*global finalizationRegistry, attachFinalizer, detachFinalizer, releaseClassHandle, runDestructor*/
 /*global ClassHandle, makeClassHandle, structRegistrations, whenDependentTypesAreResolved, BindingError, deletionQueue, delayFunction:true, upcastPointer*/
-/*global exposePublicSymbol, heap32VectorToArray, new_, RegisteredPointer_getPointee, RegisteredPointer_destructor, RegisteredPointer_deleteObject, char_0, char_9*/
+/*global exposePublicSymbol, heap32VectorToArray, newFunc, RegisteredPointer_getPointee, RegisteredPointer_destructor, RegisteredPointer_deleteObject, char_0, char_9*/
 /*global getInheritedInstanceCount, getLiveInheritedInstances, setDelayFunction, InternalError, runDestructors*/
 /*global requireRegisteredType, unregisterInheritedInstance, registerInheritedInstance, PureVirtualError, throwUnboundTypeError*/
 /*global assert, validateThis, downcastPointer, registeredPointers, RegisteredClass, getInheritedInstance, ClassHandle_isAliasOf, ClassHandle_clone, ClassHandle_isDeleted, ClassHandle_deleteLater*/
@@ -906,20 +906,12 @@ var LibraryEmbind = {
     }
   },
 
-  // Function implementation of operator new, per
-  // http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf
-  // 13.2.2
-  // ES3
-  $new___deps: ['$createNamedFunction'],
-  $new_: function(constructor, argumentList) {
+#if DYNAMIC_EXECUTION
+  $newFunc__deps: ['$createNamedFunction'],
+  $newFunc: function(constructor, argumentList) {
     if (!(constructor instanceof Function)) {
       throw new TypeError('new_ called with constructor type ' + typeof(constructor) + " which is not a function");
     }
-#if DYNAMIC_EXECUTION == 0
-    if (constructor === Function) {
-      throw new Error('new_ cannot create a new Function with DYNAMIC_EXECUTION == 0.');
-    }
-#endif
     /*
      * Previously, the following line was just:
      *   function dummy() {};
@@ -937,15 +929,19 @@ var LibraryEmbind = {
     var r = constructor.apply(obj, argumentList);
     return (r instanceof Object) ? r : obj;
   },
+#endif
 
   // The path to interop from JS code to C++ code:
   // (hand-written JS code) -> (autogenerated JS invoker) -> (template-generated C++ invoker) -> (target C++ function)
   // craftInvokerFunction generates the JS invoker function for each function exposed to JS through embind.
   $craftInvokerFunction__deps: [
-    '$makeLegalFunctionName', '$new_', '$runDestructors', '$throwBindingError',
-  #if ASYNCIFY
+    '$makeLegalFunctionName', '$runDestructors', '$throwBindingError',
+#if DYNAMIC_EXECUTION
+    '$newFunc',
+#endif
+#if ASYNCIFY
     '$Asyncify',
-  #endif
+#endif
   ],
   $craftInvokerFunction: function(humanName, argTypes, classType, cppInvokerFunc, cppTargetFunc, isAsync) {
     // humanName: a human-readable string name for the function to be generated.
@@ -1149,8 +1145,7 @@ var LibraryEmbind = {
 
     args1.push(invokerFnBody);
 
-    var invokerFunction = new_(Function, args1).apply(null, args2);
-    return invokerFunction;
+    return newFunc(Function, args1).apply(null, args2);
 #endif
   },
 

src/embind/emval.js

@@ -5,7 +5,7 @@
 
 /*global Module:true, Runtime*/
 /*global HEAP32*/
-/*global new_*/
+/*global newFunc*/
 /*global createNamedFunction*/
 /*global readLatin1String, stringToUTF8*/
 /*global requireRegisteredType, throwBindingError, runDestructors*/
@@ -414,7 +414,13 @@ var LibraryEmVal = {
 
   $emval_registeredMethods: [],
   _emval_get_method_caller__sig: 'pip',
-  _emval_get_method_caller__deps: ['$emval_addMethodCaller', '$emval_lookupTypes', '$new_', '$makeLegalFunctionName', '$emval_registeredMethods'],
+  _emval_get_method_caller__deps: [
+    '$emval_addMethodCaller', '$emval_lookupTypes',,
+    '$makeLegalFunctionName', '$emval_registeredMethods',
+#if DYNAMIC_EXECUTION
+    '$newFunc',
+#endif
+  ],
   _emval_get_method_caller: function(argCount, argTypes) {
     var types = emval_lookupTypes(argCount, argTypes);
     var retType = types[0];
@@ -479,7 +485,7 @@ var LibraryEmVal = {
         "};\n";
 
     params.push(functionBody);
-    var invokerFunction = new_(Function, params).apply(null, args);
+    var invokerFunction = newFunc(Function, params).apply(null, args);
 #endif
     returnId = emval_addMethodCaller(invokerFunction);
     emval_registeredMethods[signatureName] = returnId;