Skip to content

Commit 1161ea6

Browse files
authored
Fix browser.test_cubegeom_row_length (#24574)
GL_UNPACK_ROW_LENGTH is a WebGL2/GLES3 API that is not present in WebGL 1. Chrome seems to be lazy and allow it in WebGL 1 as well, but Firefox is strict and this test fails if not run against WebGL 2.
1 parent bf5d63c commit 1161ea6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/test_browser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2181,7 +2181,7 @@ def test_cubegeom_pre_vao_es(self):
21812181
@requires_graphics_hardware
21822182
@no_swiftshader
21832183
def test_cubegeom_row_length(self):
2184-
self.reftest('third_party/cubegeom/cubegeom_pre_vao_es.c', 'third_party/cubegeom/cubegeom_pre_vao.png', emcc_args=['-sFULL_ES2', '-lGL', '-lSDL', '-DUSE_UNPACK_ROW_LENGTH'])
2184+
self.reftest('third_party/cubegeom/cubegeom_pre_vao_es.c', 'third_party/cubegeom/cubegeom_pre_vao.png', emcc_args=['-sFULL_ES2', '-lGL', '-lSDL', '-DUSE_UNPACK_ROW_LENGTH', '-sMIN_WEBGL_VERSION=2'])
21852185

21862186
@requires_graphics_hardware
21872187
def test_cubegeom_u4fv_2(self):

0 commit comments

Comments
 (0)