Skip to content

Commit 1105368

Browse files
authored
Allow temp files to specify a prefix. NFC (#17656)
This makes debugging with EMCC_DEBUG=1 easier since the resulting files will have readable names.
1 parent 91a14f6 commit 1105368

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tools/building.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False):
630630
original_filename = filename
631631
if extra_info is not None:
632632
temp_files = shared.get_temp_files()
633-
temp = temp_files.get('.js').name
633+
temp = temp_files.get('.js', prefix='emcc_acorn_info_').name
634634
shutil.copyfile(filename, temp)
635635
with open(temp, 'a') as f:
636636
f.write('// EXTRA_INFO: ' + extra_info)
@@ -809,7 +809,7 @@ def closure_compiler(filename, pretty, advanced=True, extra_closure_args=None):
809809
if settings.WASM_FUNCTION_EXPORTS and not settings.DECLARE_ASM_MODULE_EXPORTS:
810810
# Generate an exports file that records all the exported symbols from the wasm module.
811811
module_exports_suppressions = '\n'.join(['/**\n * @suppress {duplicate, undefinedVars}\n */\nvar %s;\n' % asmjs_mangle(i) for i in settings.WASM_FUNCTION_EXPORTS])
812-
exports_file = shared.get_temp_files().get('_module_exports.js')
812+
exports_file = shared.get_temp_files().get('.js', prefix='emcc_module_exports_')
813813
exports_file.write(module_exports_suppressions.encode())
814814
exports_file.close()
815815

@@ -1065,8 +1065,8 @@ def metadce(js_file, wasm_file, minify_whitespace, debug_info):
10651065
for item in graph:
10661066
if 'import' in item:
10671067
import_name_map[item['name']] = 'emcc$import$' + item['import'][1]
1068-
temp = temp_files.get('.txt').name
1069-
utils.write_file(temp, json.dumps(graph))
1068+
temp = temp_files.get('.json', prefix='emcc_dce_graph_').name
1069+
utils.write_file(temp, json.dumps(graph, indent=2))
10701070
# run wasm-metadce
10711071
out = run_binaryen_command('wasm-metadce',
10721072
wasm_file,

tools/tempfiles.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ def __init__(self, tmpdir, save_debug_files):
7373
def note(self, filename):
7474
self.to_clean.append(filename)
7575

76-
def get(self, suffix):
76+
def get(self, suffix, prefix=None):
7777
"""Returns a named temp file with the given prefix."""
78-
named_file = tempfile.NamedTemporaryFile(dir=self.tmpdir, suffix=suffix, delete=False)
78+
named_file = tempfile.NamedTemporaryFile(dir=self.tmpdir, suffix=suffix, prefix=prefix, delete=False)
7979
self.note(named_file.name)
8080
return named_file
8181

0 commit comments

Comments
 (0)