Skip to content

Commit 0c43591

Browse files
authored
CI: pip install using EMSDK_PYTHON on windows. NFC (#16547)
Previously we could not use the emsdk version of python to run pip install, but this was fixed in emscripten-core/emsdk#1001.
1 parent 500d826 commit 0c43591

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

.circleci/config.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -423,16 +423,11 @@ jobs:
423423
- build
424424
# note we do *not* build all libraries and freeze the cache; as we run
425425
# only limited tests here, it's more efficient to build on demand
426+
- pip-install:
427+
python: "$EMSDK_PYTHON"
426428
- run-tests:
427429
test_targets: "other.test_emcc_cflags other.test_stdin other.test_bad_triple core2.test_sse1 core2.test_ccall other.test_closure_externs other.test_binaryen_debug other.test_js_optimizer_parse_error other.test_output_to_nowhere other.test_emcc_dev_null other.test_cmake* other.test_system_include_paths other.test_emar_response_file core2.test_utf16 other.test_special_chars_in_arguments other.test_toolchain_profiler other.test_realpath_nodefs other.test_response_file_encoding other.test_libc_progname other.test_realpath other.test_embed_file_dup"
428430
# Run a single websockify-based test to ensure it works on windows.
429-
# We need to do this using the system python since the emsdk version
430-
# does not have `pip` or come preloaded with `websockify`.
431-
- run:
432-
name: Set system python
433-
command: echo "export EMSDK_PYTHON=/c/Python38/python.exe" >> $BASH_ENV
434-
- pip-install:
435-
python: "$EMSDK_PYTHON"
436431
- run-tests:
437432
test_targets: "sockets.test_nodejs_sockets_echo"
438433
test-mac:

0 commit comments

Comments
 (0)