Remove likely unused FS.loadFilesFromDB and FS.saveFilesToDB helpers (#19049)

These were added back in 1b134c8 but we are not aware of anyone using
them.  We have a separate IDBFS filesystem that provides indexDB
persistence so this seems like duplicate/redundant code.

Fixes: #19025

Author: sbc100

ChangeLog.md

@@ -20,6 +20,9 @@ See docs/process.md for more on how version tagging works.
 
 3.1.35 (in development)
 -----------------------
+- `FS.loadFilesFromDB` and `FS.saveFilesToDB` were removed.  We think it's
+  unlikly there were any users of these functions since there is now a separate
+  IDBFS filesystem for folks that want persistence. (#19049)
 - `allocateUTF8` library function moved to `library_legacy.js`.  Prefer the
   more accurately named `stringToNewUTF8`.
 - `SDL_image` port was updated to version 2.6.0.

site/source/docs/api_reference/advanced-apis.rst

@@ -98,8 +98,6 @@ example, writing a new local file system) or legacy file system compatibility.
 .. js:function:: FS.quit()
 .. js:function:: FS.indexedDB()
 .. js:function:: FS.DB_NAME()
-.. js:function:: FS.saveFilesToDB(paths, onload, onerror)
-.. js:function:: FS.loadFilesFromDB(paths, onload, onerror)
 
   For advanced users only.
 

src/library_fs.js

@@ -1911,89 +1911,6 @@ FS.staticInit();` +
       }
     },
 
-    //
-    // persistence
-    //
-    indexedDB: () => {
-      return window.indexedDB || window.mozIndexedDB || window.webkitIndexedDB || window.msIndexedDB;
-    },
-
-    DB_NAME: () => {
-      return 'EM_FS_' + window.location.pathname;
-    },
-    DB_VERSION: 20,
-    DB_STORE_NAME: 'FILE_DATA',
-
-    // asynchronously saves a list of files to an IndexedDB. The DB will be created if not already existing.
-    saveFilesToDB: (paths, onload = (() => {}), onerror = (() => {})) => {
-      var indexedDB = FS.indexedDB();
-      try {
-        var openRequest = indexedDB.open(FS.DB_NAME(), FS.DB_VERSION);
-      } catch (e) {
-        return onerror(e);
-      }
-      openRequest.onupgradeneeded = () => {
-        out('creating db');
-        var db = openRequest.result;
-        db.createObjectStore(FS.DB_STORE_NAME);
-      };
-      openRequest.onsuccess = () => {
-        var db = openRequest.result;
-        var transaction = db.transaction([FS.DB_STORE_NAME], 'readwrite');
-        var files = transaction.objectStore(FS.DB_STORE_NAME);
-        var ok = 0, fail = 0, total = paths.length;
-        function finish() {
-          if (fail == 0) onload(); else onerror();
-        }
-        paths.forEach((path) => {
-          var putRequest = files.put(FS.analyzePath(path).object.contents, path);
-          putRequest.onsuccess = () => { ok++; if (ok + fail == total) finish() };
-          putRequest.onerror = () => { fail++; if (ok + fail == total) finish() };
-        });
-        transaction.onerror = onerror;
-      };
-      openRequest.onerror = onerror;
-    },
-
-    // asynchronously loads a file from IndexedDB.
-    loadFilesFromDB: (paths, onload = (() => {}), onerror = (() => {})) => {
-      var indexedDB = FS.indexedDB();
-      try {
-        var openRequest = indexedDB.open(FS.DB_NAME(), FS.DB_VERSION);
-      } catch (e) {
-        return onerror(e);
-      }
-      openRequest.onupgradeneeded = onerror; // no database to load from
-      openRequest.onsuccess = () => {
-        var db = openRequest.result;
-        try {
-          var transaction = db.transaction([FS.DB_STORE_NAME], 'readonly');
-        } catch(e) {
-          onerror(e);
-          return;
-        }
-        var files = transaction.objectStore(FS.DB_STORE_NAME);
-        var ok = 0, fail = 0, total = paths.length;
-        function finish() {
-          if (fail == 0) onload(); else onerror();
-        }
-        paths.forEach((path) => {
-          var getRequest = files.get(path);
-          getRequest.onsuccess = () => {
-            if (FS.analyzePath(path).exists) {
-              FS.unlink(path);
-            }
-            FS.createDataFile(PATH.dirname(path), PATH.basename(path), getRequest.result, true, true, true);
-            ok++;
-            if (ok + fail == total) finish();
-          };
-          getRequest.onerror = () => { fail++; if (ok + fail == total) finish() };
-        });
-        transaction.onerror = onerror;
-      };
-      openRequest.onerror = onerror;
-    },
-
     // Removed v1 functions
 #if ASSERTIONS
     absolutePath: () => {

src/preamble.js

@@ -512,7 +512,6 @@ var FS = {
   mkdev: function() { FS.error() },
   registerDevice: function() { FS.error() },
   analyzePath: function() { FS.error() },
-  loadFilesFromDB: function() { FS.error() },
 
   ErrnoError: function ErrnoError() { FS.error() },
 };

test/file_db.cpp

@@ -1345,17 +1345,6 @@ def test_write_file_in_environment_web(self):
   def test_fflush(self):
     self.btest('test_fflush.cpp', '0', args=['-sEXIT_RUNTIME', '--shell-file', test_file('test_fflush.html')], reporting=Reporting.NONE)
 
-  def test_file_db(self):
-    secret = str(time.time())
-    create_file('moar.txt', secret)
-    self.btest('file_db.cpp', '1', args=['--preload-file', 'moar.txt', '-DFIRST'])
-    shutil.copyfile('test.html', 'first.html')
-    self.btest('file_db.cpp', secret, args=['-sFORCE_FILESYSTEM'])
-    shutil.copyfile('test.html', 'second.html')
-    create_file('moar.txt', 'aliantha')
-    self.btest('file_db.cpp', secret, args=['--preload-file', 'moar.txt']) # even with a file there, we load over it
-    shutil.move('test.html', 'third.html')
-
   def test_fs_idbfs_sync(self):
     self.set_setting('DEFAULT_LIBRARY_FUNCS_TO_INCLUDE', '$ccall')
     for extra in [[], ['-DEXTRA_WORK']]:

test/test_browser.py

@@ -7497,7 +7497,6 @@ def test(contents):
     test("FS.createPreloadedFile('waka waka, just warning check')")
     test("FS.createDataFile('waka waka, just warning check')")
     test("FS.analyzePath('waka waka, just warning check')")
-    test("FS.loadFilesFromDB('waka waka, just warning check')")
     # might appear in filesystem code from a separate script tag
     test("Module['FS_createDataFile']('waka waka, just warning check')")
     test("Module['FS_createPreloadedFile']('waka waka, just warning check')")