Skip to content

Commit 06d1062

Browse files
authored
Avoid setting LC_ALL in test_browser_language_detection. NFC (#24088)
Followup to #24075. This should fix the mac failures we have been seeing
1 parent 4a6337c commit 06d1062

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/test_other.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6750,14 +6750,15 @@ def test_bad_locale(self):
67506750
self.assertContained('locale set to waka: waka',
67516751
self.run_js('a.out.js', args=['waka']))
67526752

6753-
@with_env_modify({'LC_ALL': 'en_US'})
6753+
@crossplatform
67546754
def test_browser_language_detection(self):
67556755
# Test HTTP Accept-Language parsing by simulating navigator.languages #8751
67566756
self.run_process([EMCC,
67576757
test_file('test_browser_language_detection.c')])
67586758
# We support both "C" and "en_US" here since older versions of node do
67596759
# not expose navigator.languages.
6760-
self.assertContained('LANG=(C|en_US).UTF-8', self.run_js('a.out.js'), regex=True)
6760+
lang = os.environ.get('LANG', 'C.UTF-8')
6761+
self.assertContained(f'LANG=({lang}|C.UTF-8)', self.run_js('a.out.js'), regex=True)
67616762

67626763
# Accept-Language: fr,fr-FR;q=0.8,en-US;q=0.5,en;q=0.3
67636764
create_file('pre.js', 'var navigator = { languages: [ "fr", "fr-FR", "en-US", "en" ] };')

0 commit comments

Comments
 (0)