WasmFS: Fix two more trivial closure issues (#19454)

var x = a ? b : abort() confuses closure as it doesn't know that abort is
no-return. Move the check to another line.

Author: kripken

src/library_wasi.js

@@ -519,8 +519,12 @@ var WasiLibrary = {
                  FS.isLink(stream.mode) ? {{{ cDefs.__WASI_FILETYPE_SYMBOLIC_LINK }}} :
                  {{{ cDefs.__WASI_FILETYPE_REGULAR_FILE }}};
 #else
-      // hack to support printf in SYSCALLS_REQUIRE_FILESYSTEM=0
-      var type = fd == 0 || fd == 1 || fd == 2 ? {{{ cDefs.__WASI_FILETYPE_CHARACTER_DEVICE }}} : abort();
+      // Hack to support printf in SYSCALLS_REQUIRE_FILESYSTEM=0. We support at
+      // least stdin, stdout, stderr in a simple way.
+#if ASSERTIONS
+      assert(fd == 0 || fd == 1 || fd == 2);
+#endif
+      var type = {{{ cDefs.__WASI_FILETYPE_CHARACTER_DEVICE }}};
       if (fd == 0) {
         rightsBase = {{{ cDefs.__WASI_RIGHTS_FD_READ }}};
       } else if (fd == 1 || fd == 2) {

src/library_wasmfs_opfs.js

@@ -71,6 +71,11 @@ mergeInto(LibraryManager.library, {
   _wasmfs_opfs_init_root_directory: async function(ctx) {
     // allocated.length starts off as 1 since 0 is a reserved handle
     if (wasmfsOPFSDirectoryHandles.allocated.length == 1) {
+      // Closure compiler errors on this as it does not recognize the OPFS
+      // API yet, it seems. Unfortunately an existing annotation for this is in
+      // the closure compiler codebase, and cannot be overridden in user code
+      // (it complains on a duplicate type annotation), so just suppress it.
+      /** @suppress {checkTypes} */
       let root = await navigator.storage.getDirectory();
       wasmfsOPFSDirectoryHandles.allocated.push(root);
     }