Skip to content

Commit e63cbfe

Browse files
authored
Don't fail on untranslated strings (#312)
Currently CI would fail on untranslated strings, but during development this is to be expected. So we check now for both, but don't fail for untranslated strings.
1 parent 2d2fded commit e63cbfe

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,11 @@ jobs:
3131
run: python -m tox -q -e flake8,py
3232
- name: Run pylint
3333
run: python -m pylint lib/ tests/
34-
- name: Compare translations
34+
- name: Compare translation strings
3535
run: make check-translations
36+
- name: Check for untranslated strings
37+
run: make check-untranslated
38+
continue-on-error: true
3639
# Python 2.7 and Python 3.5 are no longer supported by proxy.py
3740
- name: Start proxy server, when supported
3841
run: python -m proxy --hostname 127.0.0.1 --log-level DEBUG &

Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ check-pylint:
4040
$(PYTHON) -m pylint -e useless-suppression lib/ tests/
4141

4242
check-translations:
43+
@echo -e "$(white)=$(blue) Starting language test$(reset)"
44+
@-$(foreach lang,$(languages), \
45+
msgcmp --use-untranslated resources/language/resource.language.$(lang)/strings.po resources/language/resource.language.en_gb/strings.po; \
46+
)
47+
48+
check-untranslated:
4349
@echo -e "$(white)=$(blue) Starting language test$(reset)"
4450
@-$(foreach lang,$(languages), \
4551
msgcmp resources/language/resource.language.$(lang)/strings.po resources/language/resource.language.en_gb/strings.po; \

0 commit comments

Comments
 (0)