Skip to content

Commit 5c22e11

Browse files
authored
Remove id from settings entries (#233)
We currently have the id attribute added to entries in the settings.xml that don't need it. And this results in entries in the user's settings for things that don't store values. So we ought to remove them to keep the user settings clean.
1 parent 5c66c5f commit 5c22e11

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

resources/settings.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
<setting id="version" value="" visible="false"/>
55
<setting id="chromeos_version" value="" visible="false"/>
66
<category label="30900"> <!-- Expert -->
7-
<setting label="30901" type="action" id="info" action="RunScript(script.module.inputstreamhelper, info)"/>
7+
<setting label="30901" help="30902" type="action" action="RunScript(script.module.inputstreamhelper, info)"/>
88
<setting type="sep"/>
99
<setting label="30903" help="30904" type="bool" id="disabled" default="false"/>
10-
<setting label="30904" type="text" id="warning" enable="false"/> <!-- disabled_warning -->
10+
<setting label="30904" type="text" enable="false"/> <!-- disabled_warning -->
1111
<setting label="30905" help="30906" type="slider" id="update_frequency" default="31" range="1,3,90" option="int" enable="eq(-2,false)" visible="!system.platform.android"/>
1212
<setting label="30907" help="30908" type="folder" id="temp_path" source="" option="writeable" default="special://masterprofile/addon_data/script.module.inputstreamhelper" visible="!system.platform.android"/>
1313
<setting label="30913" help="30914" type="slider" id="backups" default="4" range="0,1,20" option="int" visible="!system.platform.android"/>
1414
<setting type="sep" visible="!system.platform.android"/>
15-
<setting label="30909" help="30910" type="action" id="install_widevine" action="RunScript(script.module.inputstreamhelper, widevine_install)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
16-
<setting label="30911" help="30912" type="action" id="remove_widevine" action="RunScript(script.module.inputstreamhelper, widevine_remove)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
17-
<setting label="30915" help="30916" type="action" id="rollback" action="RunScript(script.module.inputstreamhelper, rollback)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
15+
<setting label="30909" help="30910" type="action" action="RunScript(script.module.inputstreamhelper, widevine_install)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
16+
<setting label="30911" help="30912" type="action" action="RunScript(script.module.inputstreamhelper, widevine_remove)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
17+
<setting label="30915" help="30916" type="action" action="RunScript(script.module.inputstreamhelper, rollback)" enable="System.HasAddon(inputstream.adaptive)" visible="!system.platform.android"/>
1818
</category>
1919
</settings>

0 commit comments

Comments
 (0)