Remove toStringExtension

Author: wagenet

packages/@ember/object/core.ts

@@ -20,18 +20,6 @@ import { DEBUG } from '@glimmer/env';
 import { destroy, isDestroying, isDestroyed, registerDestructor } from '@glimmer/destroyable';
 import { OWNER } from '@glimmer/owner';
 
-interface HasToStringExtension {
-  toStringExtension: () => void;
-}
-
-function hasToStringExtension(val: unknown): val is HasToStringExtension {
-  return (
-    typeof val === 'object' &&
-    val !== null &&
-    typeof (val as HasToStringExtension).toStringExtension === 'function'
-  );
-}
-
 const wasApplied = new WeakSet();
 
 const initCalled = DEBUG ? new WeakSet() : undefined; // only used in debug builds to enable the proxy trap
@@ -376,27 +364,12 @@ class CoreObject {
     student.toString(); //=> "<(subclass of Person):ember1025>"
     ```
 
-    If the method `toStringExtension` is defined, its return value will be
-    included in the output.
-
-    ```javascript
-    const Teacher = Person.extend({
-      toStringExtension() {
-        return this.get('fullName');
-      }
-    });
-    teacher = Teacher.create();
-    teacher.toString(); //=> "<Teacher:ember1026:Tom Dale>"
-    ```
-
     @method toString
     @return {String} string representation
     @public
   */
   toString() {
-    let extension = hasToStringExtension(this) ? `:${this.toStringExtension()}` : '';
-
-    return `<${getFactoryFor(this) || '(unknown)'}:${guidFor(this)}${extension}>`;
+    return `<${getFactoryFor(this) || '(unknown)'}:${guidFor(this)}>`;
   }
 
   /**

packages/@ember/object/tests/toString_test.js

@@ -5,29 +5,16 @@ import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
 moduleFor(
   'system/object/toString',
   class extends AbstractTestCase {
-    ['@test toString includes toStringExtension if defined'](assert) {
-      let Foo = class extends CoreObject {
-        toStringExtension() {
-          return 'fooey';
-        }
-      };
+    ['@test toString'](assert) {
+      let Foo = class extends CoreObject {};
       let foo = Foo.create();
-      let Bar = class extends CoreObject {};
-      let bar = Bar.create();
 
       // simulate these classes being defined on a Namespace
       setName(Foo, 'Foo');
-      setName(Bar, 'Bar');
 
-      assert.equal(
-        bar.toString(),
-        '<(unknown):' + guidFor(bar) + '>',
-        'does not include toStringExtension part'
-      );
       assert.equal(
         foo.toString(),
-        '<(unknown):' + guidFor(foo) + ':fooey>',
-        'Includes toStringExtension result'
+        '<(unknown):' + guidFor(foo) + '>'
       );
     }
   }