Merge pull request #20333 from olenderhub/docs/routing/didTransition

chriskrycho · web-flow · commit 15a87bdbb18e · 2023-01-23T09:00:08.000-07:00
[DOC] Improve didTransition in routing
diff --git a/packages/@ember/routing/route.ts b/packages/@ember/routing/route.ts
@@ -145,7 +145,7 @@ interface Route<T = unknown> extends IRoute<T> {
     export default class LoginRoute extends Route {
       @action
       didTransition() {
-        this.controller.get('errors.base').clear();
+        // your code there
         return true; // Bubble the didTransition event
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ interface Route<T = unknown> extends IRoute<T> {`
`145`	`145`	`export default class LoginRoute extends Route {`
`146`	`146`	`@action`
`147`	`147`	`didTransition() {`
`148`		`- this.controller.get('errors.base').clear();`
	`148`	`+ // your code there`
`149`	`149`	`return true; // Bubble the didTransition event`
`150`	`150`	`}`
`151`	`151`	`}`