Skip to content

Commit f4c2577

Browse files
ybakosJen Weber
authored andcommitted
routes-and-templates: Fix anchor parameters in documentation links. (#168)
The URLs here have a trailing slash, considered part of the anchor, which results in the link taking a user to the top of the doc page, rather than the specific anchored method within the doc page. Remove the trailing slash, so the anchor is accurate, and the user is taken directly to the appropriate method in the doc page.
1 parent 062985e commit f4c2577

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

guides/v2.18.0/tutorial/routes-and-templates.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ hook gets executed before the data gets fetched from the model hook, and before
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227227
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

guides/v3.0.0/tutorial/routes-and-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ The [`beforeModel`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods
224224
hook gets executed before the data gets fetched from the model hook, and before the page is rendered.
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227-
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/beforeModel?anchor=replaceWith/) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
227+
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/2.16/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

guides/v3.1.0/tutorial/routes-and-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ The [`beforeModel`](https://www.emberjs.com/api/ember/release/classes/Route/meth
224224
hook gets executed before the data gets fetched from the model hook, and before the page is rendered.
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227-
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith/) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
227+
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

guides/v3.2.0/tutorial/routes-and-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ The [`beforeModel`](https://www.emberjs.com/api/ember/release/classes/Route/meth
224224
hook gets executed before the data gets fetched from the model hook, and before the page is rendered.
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227-
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith/) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
227+
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

guides/v3.3.0/tutorial/routes-and-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ The [`beforeModel`](https://www.emberjs.com/api/ember/release/classes/Route/meth
224224
hook gets executed before the data gets fetched from the model hook, and before the page is rendered.
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227-
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith/) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
227+
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

guides/v3.4.0/tutorial/routes-and-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ The [`beforeModel`](https://www.emberjs.com/api/ember/release/classes/Route/meth
224224
hook gets executed before the data gets fetched from the model hook, and before the page is rendered.
225225
See [the next section](../model-hook/) for an explanation of the model hook.
226226

227-
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith/) function.
228-
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo/) function,
227+
In our index route handler, we'll call the [`replaceWith`](https://www.emberjs.com/api/ember/release/classes/Route/methods/beforeModel?anchor=replaceWith) function.
228+
The `replaceWith` function is similar to the route's [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) function,
229229
the difference being that `replaceWith` will replace the current URL in the browser's history,
230230
while `transitionTo` will add to the history.
231231
Since we want our `rentals` route to serve as our home page, we will use the `replaceWith` function.

0 commit comments

Comments
 (0)