Skip to content

Commit 7d510ad

Browse files
authored
Merge pull request #1074 from simonihmig/update-node
Update to node 20
2 parents cfe915c + 8838b6b commit 7d510ad

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
pull_request:
88

99
env:
10-
NODE_VERSION: 14
10+
NODE_VERSION: 20
1111
PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }}
1212
PERCY_PARALLEL_TOTAL: 1
1313

@@ -28,16 +28,12 @@ jobs:
2828
cache: 'npm'
2929
node-version: ${{ env.NODE_VERSION }}
3030

31-
- name: Update npm
32-
run: npm i -g npm@7
33-
3431
- name: Install dependencies
3532
run: npm ci
3633

3734
- name: Lint
3835
run: npm run lint
3936

40-
4137
test-app:
4238
name: Test app
4339
runs-on: ubuntu-latest
@@ -52,9 +48,6 @@ jobs:
5248
cache: 'npm'
5349
node-version: ${{ env.NODE_VERSION }}
5450

55-
- name: Update npm
56-
run: npm i -g npm@7
57-
5851
- name: Install dependencies
5952
run: npm ci
6053

@@ -65,7 +58,6 @@ jobs:
6558
PERCY_PARALLEL_TOTAL: ${{ env.PERCY_PARALLEL_TOTAL }}
6659
PERCY_TOKEN: c08aaada222e9cb103a28b98e94d71ff8baaddb5a548237432d900f1d4a9ec27
6760

68-
6961
lighthouse-ci:
7062
name: Run Lighthouse
7163
runs-on: ubuntu-latest
@@ -82,9 +74,6 @@ jobs:
8274
cache: 'npm'
8375
node-version: ${{ env.NODE_VERSION }}
8476

85-
- name: Update npm
86-
run: npm i -g npm@7
87-
8877
- name: Install dependencies
8978
run: npm ci
9079

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
"webpack": "^5.76.0"
9595
},
9696
"engines": {
97-
"node": "12.* || 14.* || >= 16"
97+
"node": ">= 20"
9898
},
9999
"ember": {
100100
"edition": "octane"
@@ -108,7 +108,6 @@
108108
"algoliasearch"
109109
],
110110
"volta": {
111-
"node": "14.16.0",
112-
"npm": "8.5.3"
111+
"node": "20.10.0"
113112
}
114113
}

0 commit comments

Comments
 (0)