Skip to content

Commit b15f6a9

Browse files
authored
Merge pull request #488 from ember-learn/drop-node-14
drop support for EOL node < 18
2 parents 15bae44 + 6c1aa57 commit b15f6a9

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@ jobs:
2121
- uses: actions/checkout@v2
2222
- uses: actions/setup-node@v3
2323
with:
24-
node-version: 14.x
24+
node-version: 18.x
2525
cache: npm
26-
- run: npm i -g npm@8
2726
- run: npm ci
2827
- run: npx percy exec -- npm run test:docs
2928

@@ -36,9 +35,8 @@ jobs:
3635
- uses: mansona/npm-lockfile-version@v1
3736
- uses: actions/setup-node@v3
3837
with:
39-
node-version: 14.x
38+
node-version: 18.x
4039
cache: npm
41-
- run: npm i -g npm@8
4240
- run: npm ci
4341
- run: npm run lint
4442
- run: npx percy exec -- npm run test
@@ -51,9 +49,8 @@ jobs:
5149
- uses: actions/checkout@v2
5250
- uses: actions/setup-node@v3
5351
with:
54-
node-version: 14.x
52+
node-version: 18.x
5553
cache: npm
56-
- run: npm i -g npm@8
5754
- run: npm install --no-shrinkwrap
5855
- run: npm run test:ember
5956

@@ -82,9 +79,8 @@ jobs:
8279
- uses: actions/checkout@v2
8380
- uses: actions/setup-node@v3
8481
with:
85-
node-version: 14.x
82+
node-version: 18.x
8683
cache: npm
87-
- run: npm i -g npm@8
8884
- run: npm ci
8985
- name: Run Tests
9086
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
@@ -107,9 +103,8 @@ jobs:
107103
- uses: actions/checkout@v2
108104
- uses: actions/setup-node@v3
109105
with:
110-
node-version: 14.x
106+
node-version: 18.x
111107
cache: npm
112-
- run: npm i -g npm@8
113108
- run: npm ci
114109
- name: Run Tests
115110
id: tests

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
"webpack": "^5.52.1"
112112
},
113113
"engines": {
114-
"node": "12.* || 14.* || >= 16"
114+
"node": "18.* || >= 20"
115115
},
116116
"ember": {
117117
"edition": "octane"
@@ -120,6 +120,6 @@
120120
"configPath": "tests/dummy/config"
121121
},
122122
"volta": {
123-
"node": "16.20.1"
123+
"node": "18.18.2"
124124
}
125125
}

0 commit comments

Comments
 (0)