fix lint on navbar link

Author: mansona

addon/components/es-header/navbar-link.js

@@ -4,6 +4,7 @@ import { computed } from '@ember/object';
 import { equal } from '@ember/object/computed';
 import { inject as service } from '@ember/service';
 import { schedule, next } from '@ember/runloop';
+import { action } from '@ember/object';
 
 export default Component.extend({
   layout,
@@ -47,26 +48,25 @@ export default Component.extend({
     });
   },
 
-  actions: {
-    toggleDropdown(event) {
-      this.get('navbar').closePopupMenu(this);
-      this.toggleProperty('isDropdownOpen');
+  @action
+  toggleDropdown(event) {
+    this.get('navbar').closePopupMenu(this);
+    this.toggleProperty('isDropdownOpen');
 
-      if (this.isDropdownOpen) {
-        // if it's open, let's make sure it can do some things
-        schedule('afterRender', this, function() {
-          this.setupLinkBlurs();
+    if (this.isDropdownOpen) {
+      // if it's open, let's make sure it can do some things
+      schedule('afterRender', this, function() {
+        this.setupLinkBlurs();
 
-          // move focus to the first item in the dropdown only when opened with keyboard
-          // ref https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/detail
-          if (event.detail === 0) {
-            this.processFirstElementFocus();
-          }
+        // move focus to the first item in the dropdown only when opened with keyboard
+        // ref https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/detail
+        if (event.detail === 0) {
+          this.processFirstElementFocus();
+        }
 
-          this.processKeyPress();
-        });
-      }
-    },
+        this.processKeyPress();
+      });
+    }
   },
 
   closeDropdown() {

addon/components/es-header/template.hbs

@@ -1,22 +1,23 @@
-{{#if (eq link.type "link")}}
+{{#if (eq @link.type "link")}}
   <a
     class="navbar-list-item-link"
-    href={{link.href}}
+    href={{@link.href}}
   >
-    {{link.name}}
+    {{@link.name}}
   </a>
 {{/if}}
-{{#if (eq link.type "dropdown")}}
+{{#if (eq @link.type "dropdown")}}
   <button
-    onclick={{action "toggleDropdown"}}
-    class="navbar-list-item-dropdown-toggle {{if isDropdownOpen "active"}}"
-    aria-expanded={{isExpanded}}
+    type="button"
+    class="navbar-list-item-dropdown-toggle {{if this.isDropdownOpen "active"}}"
+    aria-expanded={{this.isExpanded}}
+    {{on "click" this.toggleDropdown}}
   >
-    {{link.name}}
+    {{@link.name}}
   </button>
-  {{#if isDropdownOpen}}
+  {{#if this.isDropdownOpen}}
     <ul class="navbar-dropdown-list">
-      {{#each link.items as |item|}}
+      {{#each @link.items as |item|}}
         {{#if (eq item.type "link")}}
           <li class="navbar-dropdown-list-item">
             <a
@@ -33,4 +34,4 @@
       {{/each}}
     </ul>
   {{/if}}
-{{/if}}
+{{/if}}