Skip to content

Commit 35ae4d3

Browse files
author
ignace
committed
chore: use node-fetch and revert to node v16
1 parent 12c31df commit 35ae4d3

File tree

4 files changed

+28
-3
lines changed

4 files changed

+28
-3
lines changed

.github/workflows/ci-cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
pull_request:
88

99
env:
10-
NODE_VERSION: 18
10+
NODE_VERSION: 16
1111
PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }}
1212
PERCY_PARALLEL_TOTAL: 1
1313

config/fastboot.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ module.exports = function () {
44
return {
55
buildSandboxGlobals(defaultGlobals) {
66
return Object.assign({}, defaultGlobals, {
7-
fetch: fetch,
8-
// WebAssembly: require('WebAssembly'),
7+
fetch: require('node-fetch'),
98
AbortController,
109
ReadableStream:
1110
typeof ReadableStream !== 'undefined'

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
"eslint-plugin-prettier": "^4.0.0",
7373
"eslint-plugin-qunit": "^7.3.0",
7474
"loader.js": "^4.7.0",
75+
"node-fetch": "^2.7.0",
7576
"npm-run-all": "^4.1.5",
7677
"prember": "^1.1.0",
7778
"prettier": "^2.7.1",

yarn.lock

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9689,6 +9689,13 @@ node-fetch@^2.6.0, node-fetch@^2.6.1:
96899689
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.1.tgz#045bd323631f76ed2e2b55573394416b639a0052"
96909690
integrity sha512-V4aYg89jEoVRxRb2fJdAg8FHvI7cEyYdVAh94HH0UIK8oJxUfkjlDQN9RbMx+bEjP7+ggMiFRprSti032Oipxw==
96919691

9692+
node-fetch@^2.7.0:
9693+
version "2.7.0"
9694+
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.7.0.tgz#d0f0fa6e3e2dc1d27efcd8ad99d550bda94d187d"
9695+
integrity sha512-c4FRfUm/dbcWZ7U+1Wq0AwCyFL+3nt2bEw05wfxSz+DWpWsitgmSgYmy2dQdWyKC1694ELPqMs/YzUSNozLt8A==
9696+
dependencies:
9697+
whatwg-url "^5.0.0"
9698+
96929699
node-int64@^0.4.0:
96939700
version "0.4.0"
96949701
resolved "https://registry.yarnpkg.com/node-int64/-/node-int64-0.4.0.tgz#87a9065cdb355d3182d8f94ce11188b825c68a3b"
@@ -12326,6 +12333,11 @@ tr46@^3.0.0:
1232612333
dependencies:
1232712334
punycode "^2.1.1"
1232812335

12336+
tr46@~0.0.3:
12337+
version "0.0.3"
12338+
resolved "https://registry.yarnpkg.com/tr46/-/tr46-0.0.3.tgz#8184fd347dac9cdc185992f3a6622e14b9d9ab6a"
12339+
integrity sha512-N3WMsuqV66lT30CrXNbEjx4GEwlow3v6rr4mCcv6prnfwhS01rkgyFdjPNBYd9br7LpXV1+Emh01fHnq2Gdgrw==
12340+
1232912341
tree-sync@^1.2.2:
1233012342
version "1.4.0"
1233112343
resolved "https://registry.yarnpkg.com/tree-sync/-/tree-sync-1.4.0.tgz#314598d13abaf752547d9335b8f95d9a137100d6"
@@ -12801,6 +12813,11 @@ wcwidth@^1.0.1:
1280112813
dependencies:
1280212814
defaults "^1.0.3"
1280312815

12816+
webidl-conversions@^3.0.0:
12817+
version "3.0.1"
12818+
resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-3.0.1.tgz#24534275e2a7bc6be7bc86611cc16ae0a5654871"
12819+
integrity sha512-2JAn3z8AR6rjK8Sm8orRC0h/bcl/DqL7tRPdGZ4I1CjdF+EaMLmYxBHyXuKL849eucPFhvBoxMsflfOb8kxaeQ==
12820+
1280412821
webidl-conversions@^5.0.0:
1280512822
version "5.0.0"
1280612823
resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-5.0.0.tgz#ae59c8a00b121543a2acc65c0434f57b0fc11aff"
@@ -12947,6 +12964,14 @@ whatwg-url@^11.0.0:
1294712964
tr46 "^3.0.0"
1294812965
webidl-conversions "^7.0.0"
1294912966

12967+
whatwg-url@^5.0.0:
12968+
version "5.0.0"
12969+
resolved "https://registry.yarnpkg.com/whatwg-url/-/whatwg-url-5.0.0.tgz#966454e8765462e37644d3626f6742ce8b70965d"
12970+
integrity sha512-saE57nupxk6v3HY35+jzBwYa0rKSy0XR8JSxZPwgLr7ys0IBzhGviA1/TUGJLmSVqs8pb9AnvICXEuOHLprYTw==
12971+
dependencies:
12972+
tr46 "~0.0.3"
12973+
webidl-conversions "^3.0.0"
12974+
1295012975
whatwg-url@^8.0.0:
1295112976
version "8.4.0"
1295212977
resolved "https://registry.yarnpkg.com/whatwg-url/-/whatwg-url-8.4.0.tgz#50fb9615b05469591d2b2bd6dfaed2942ed72837"

0 commit comments

Comments
 (0)