Skip to content

Commit 916cd86

Browse files
committed
fix: Remove ember-cli-string-helpers
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues - Since we have `capitalize` in @ember/string, we can just call that in our internal helper - Also bumped internal version of @ember/string to v4.x Fixes #1666
1 parent 6c7633e commit 916cd86

File tree

5 files changed

+25
-17
lines changed

5 files changed

+25
-17
lines changed

addon/helpers/capitalize.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { helper } from '@ember/component/helper';
2+
import { capitalize } from '@ember/string';
3+
4+
export default helper(function capitalizeHelper(positional) {
5+
return capitalize(positional[0]);
6+
});

app/helpers/capitalize.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { default } from 'ember-cli-addon-docs/helpers/capitalize';

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
"ember-cli-clipboard": "^1.2.1",
5454
"ember-cli-htmlbars": "^6.3.0",
5555
"ember-cli-postcss": "^8.2.0",
56-
"ember-cli-string-helpers": "^6.1.0",
5756
"ember-cli-string-utils": "^1.1.0",
5857
"ember-cli-version-checker": "^5.1.2",
5958
"ember-code-snippet": "^3.0.0",

pnpm-lock.yaml

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { module, test } from 'qunit';
2+
import { setupRenderingTest } from 'dummy/tests/helpers';
3+
import { render } from '@ember/test-helpers';
4+
import { hbs } from 'ember-cli-htmlbars';
5+
import { capitalize } from '@ember/string';
6+
7+
module('Integration | Helper | capitalize', function (hooks) {
8+
setupRenderingTest(hooks);
9+
10+
test('it renders', async function (assert) {
11+
const testString = 'abc 123 ABC !@# Foo Bar';
12+
this.set('inputValue', testString);
13+
14+
await render(hbs`{{capitalize this.inputValue}}`);
15+
16+
assert.dom().hasText(capitalize(testString));
17+
});
18+
});

0 commit comments

Comments
 (0)