Skip to content

Multiple meta tags inserted into head-footer when multiple addons use ManifestGenerator #77

@brettburley

Description

@brettburley

When an application has more than one ember addon installed that exports a ManifestGenerator-extended addon, a meta tag is inserted into the head-footer content-for block because each addon has a contentFor hook defined by ManifestGenerator:

contentFor: function(type, config) {

For example, with two addons that use ManifestGenerator, before post-processing, the index.html may look like:

<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">
<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">

After post-processing, the first meta tag is replaced by the contents of the asset manifests provided by both addons, so it has all of the correct content, but there is an extraneous meta tag that remains:

<meta name="my-app/config/asset-manifest" content="%7B%22bundles%22%3A%7B%22...">
<meta name="my-app/config/asset-manifest" content="%GENERATED_ASSET_MANIFEST%">

Ideally even if multiple addons consumed by the host app are using ManifestGenerator, only a single asset-manifest meta tag would be inserted, or the extra ones be removed during the post-processing when the manifest is being injected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions