Use MockResolver in tests

Author: gitKrystan

TODO.md

@@ -18,6 +18,8 @@
 
 FIXME: Mock resolver in tests + unit test the two resolvers.
 
+FIXME: Refactor cli.js
+
 FIXME: Figure out how to pass no-babel option to jscodeshift via codemod-cli
 
 FIXME: Extract ember codemod buildtime resolver

transforms/no-implicit-this/__testfixtures__/-mock-telemetry.d.json.ts

@@ -2,7 +2,7 @@ import { getOptions as getCLIOptions } from 'codemod-cli';
 import fs from 'node:fs';
 import path from 'node:path';
 import { ZodError, ZodType, z } from 'zod';
-import Resolver, { EmbroiderResolver, RuntimeResolver } from './resolver';
+import Resolver, { EmbroiderResolver, MockResolver, RuntimeResolver } from './resolver';
 
 export interface Options {
   customHelpers: string[];
@@ -33,11 +33,18 @@ export function getOptions(): Options {
   const cliOptions = parse(getCLIOptions(), CLIOptions);
   return {
     customHelpers: getCustomHelpersFromConfig(cliOptions.config),
-    resolver:
-      cliOptions.telemetry === 'runtime' ? RuntimeResolver.build() : EmbroiderResolver.build(),
+    resolver: buildResolver(cliOptions),
   };
 }
 
+function buildResolver(cliOptions: CLIOptions): Resolver {
+  if (process.env['TESTING']) {
+    return MockResolver.build();
+  } else {
+    return cliOptions.telemetry === 'runtime' ? RuntimeResolver.build() : EmbroiderResolver.build();
+  }
+}
+
 // FIXME: Document
 /**
  * Accepts the config path for custom helpers and returns the array of helpers

transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json

@@ -108,3 +108,31 @@ export class EmbroiderResolver extends Resolver {
     }
   }
 }
+
+export class MockResolver extends Resolver {
+  private static components: string[] = [];
+  static setComponents(components: string[]) {
+    this.components = components;
+  }
+
+  private static helpers: string[] = [];
+  static setHelpers(helpers: string[]) {
+    this.helpers = helpers;
+  }
+
+  static build(): MockResolver {
+    return new MockResolver(this.components, this.helpers);
+  }
+
+  constructor(private components: string[], private helpers: string[]) {
+    super();
+  }
+
+  hasComponent(name: string): boolean {
+    return !!this.components.includes(name);
+  }
+
+  hasHelper(name: string): boolean {
+    return !!this.helpers.includes(name);
+  }
+}

transforms/no-implicit-this/helpers/options.ts

@@ -1,16 +1,18 @@
-import { setTelemetry } from 'ember-codemods-telemetry-helpers';
-import path from 'node:path';
-import mockTelemetryData, { type Telemetry } from './__testfixtures__/-mock-telemetry.json';
+import { MockResolver } from './helpers/resolver';
 
-export function setupTelemetry() {
-  const mockTelemetry: Telemetry = {};
+const MOCK_COMPONENTS = [
+  'block-component',
+  'foo-bar-baz',
+  'foo',
+  'my-component',
+  'namespace/foo',
+  'namespace/my-component',
+  'some-component',
+];
 
-  Object.keys(mockTelemetryData).forEach((key) => {
-    const value = mockTelemetryData[key] || {};
-    const mockPath = path.resolve(__dirname, `./__testfixtures__/${key}`);
+const MOCK_HELPERS = ['a-helper', 'my-helper'];
 
-    mockTelemetry[mockPath] = value;
-  });
-
-  setTelemetry(mockTelemetry);
+export function setupResolver() {
+  MockResolver.setComponents(MOCK_COMPONENTS);
+  MockResolver.setHelpers(MOCK_HELPERS);
 }

transforms/no-implicit-this/helpers/resolver.ts

@@ -1,9 +1,11 @@
 'use strict';
 
 import { runTransformTest } from 'codemod-cli';
-import { setupTelemetry } from './test-helpers';
+import { setupResolver } from './test-helpers';
 
-setupTelemetry();
+process.env['TESTING'] = 'true';
+
+setupResolver();
 
 runTransformTest({
   type: 'jscodeshift',