Add unit test for EmbroiderResolver

Author: gitKrystan

TODO.md

@@ -16,10 +16,10 @@
 2. Look at second arg to `compatBuild`
 3. ...?
 
-FIXME: Mock resolver in tests + unit test the two resolvers.
-
 FIXME: Refactor cli.js
 
+FIXME: Clean up logging shenanigans (e.g. console.log/info, debug)
+
 FIXME: Figure out how to pass no-babel option to jscodeshift via codemod-cli
 
 FIXME: Extract ember codemod buildtime resolver

transforms/no-implicit-this/helpers/resolver.ts

@@ -70,6 +70,12 @@ const EMBROIDER_COMPONENTS = '#embroider_compat/components';
 const EMBROIDER_HELPERS = '#embroider_compat/helpers';
 const EMBROIDER_AMBIGUOUS = '#embroider_compat/ambiguous';
 
+export type NodeResolution = { type: 'virtual' } | { type: 'real' } | { type: 'not_found' };
+
+export interface HasNodeResolve {
+  nodeResolve(specifier: string, fromFile: string): NodeResolution;
+}
+
 export class EmbroiderResolver extends Resolver {
   static build(): EmbroiderResolver {
     // FIXME: Run build via execa ???
@@ -80,7 +86,7 @@ export class EmbroiderResolver extends Resolver {
     return new EmbroiderResolver(resolver, resolve(stage2Output, 'app.js'));
   }
 
-  constructor(private _resolver: _EmbroiderResolver, private entryPoint: string) {
+  constructor(private _resolver: HasNodeResolve, private entryPoint: string) {
     super();
   }
 

transforms/no-implicit-this/test.ts

@@ -3,7 +3,12 @@
 import { describe, expect, test } from '@jest/globals';
 import { runTransformTest } from 'codemod-cli';
 import { setTelemetry } from 'ember-codemods-telemetry-helpers';
-import { RuntimeResolver } from './helpers/resolver';
+import {
+  EmbroiderResolver,
+  HasNodeResolve,
+  NodeResolution,
+  RuntimeResolver,
+} from './helpers/resolver';
 import { setupResolver } from './test-helpers';
 
 process.env['TESTING'] = 'true';
@@ -63,4 +68,43 @@ describe('Resolver', () => {
       expect(resolver.has('ambiguous', 'nope')).toBe(false);
     });
   });
+
+  describe('EmbroiderResolver', () => {
+    test('.has', () => {
+      const entryPoint = 'foo';
+      class mockNodeResolver implements HasNodeResolve {
+        nodeResolve(specifier: string, fromFile: string): NodeResolution {
+          expect(fromFile).toEqual(entryPoint);
+          const resolution = {
+            '#embroider_compat/components/gherkyn': 'real' as const,
+            '#embroider_compat/ambiguous/gherkyn': 'real' as const,
+            '#embroider_compat/components/welcome-page': 'real' as const,
+            '#embroider_compat/ambiguous/welcome-page': 'real' as const,
+            '#embroider_compat/helpers/cucumbyr': 'real' as const,
+            '#embroider_compat/ambiguous/cucumbyr': 'real' as const,
+            '#embroider_compat/ambiguous/virtual': 'virtual' as const,
+          }[specifier];
+          return { type: resolution ?? 'not_found' };
+        }
+      }
+
+      const resolver = new EmbroiderResolver(new mockNodeResolver(), entryPoint);
+
+      expect(resolver.has('component', 'gherkyn')).toBe(true);
+      expect(resolver.has('component', 'welcome-page')).toBe(true);
+      expect(resolver.has('component', 'cucumbyr')).toBe(false);
+      expect(resolver.has('component', 'nope')).toBe(false);
+
+      expect(resolver.has('helper', 'gherkyn')).toBe(false);
+      expect(resolver.has('helper', 'welcome-page')).toBe(false);
+      expect(resolver.has('helper', 'cucumbyr')).toBe(true);
+      expect(resolver.has('helper', 'nope')).toBe(false);
+
+      expect(resolver.has('ambiguous', 'gherkyn')).toBe(true);
+      expect(resolver.has('ambiguous', 'welcome-page')).toBe(true);
+      expect(resolver.has('ambiguous', 'cucumbyr')).toBe(true);
+      expect(resolver.has('ambiguous', 'nope')).toBe(false);
+      expect(resolver.has('ambiguous', 'virtual')).toBe(true);
+    });
+  });
 });