Skip to content

Commit f8d8fd2

Browse files
authored
Merge pull request #211 from patocallaghan/patoc/class-bugs
Don't append object name when type is already at the end of the filename
2 parents 5d635b3 + b2cd0d8 commit f8d8fd2

File tree

5 files changed

+16
-2
lines changed

5 files changed

+16
-2
lines changed

transforms/ember-object/__testfixtures__/-mock-telemetry.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@
4141
"types/services/basic": {
4242
"type": "Service"
4343
},
44+
"types/services/some-service": {
45+
"type": "Service"
46+
},
4447
"types/pods/foo/controller": {
4548
"type": "Controller"
4649
},

transforms/ember-object/__testfixtures__/injecting-service.output.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import classic from 'ember-classic-decorator';
22
import Service, { service as injectService } from '@ember/service';
33

44
@classic
5-
export default class InjectingServiceService extends Service {
5+
export default class InjectingService extends Service {
66
@injectService()
77
something;
88

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import Service from '@ember/service';
2+
3+
export default Service.extend();
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import classic from 'ember-classic-decorator';
2+
import Service from '@ember/service';
3+
4+
@classic
5+
export default class SomeService extends Service {}

transforms/helpers/parse-helper.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,10 @@ export function getClassName(
104104
);
105105
}
106106

107-
if (!['Component', 'Helper', 'EmberObject'].includes(type)) {
107+
if (
108+
!['Component', 'Helper', 'EmberObject'].includes(type) &&
109+
!className.endsWith(type)
110+
) {
108111
className = `${className}${capitalizedType}`;
109112
}
110113

0 commit comments

Comments
 (0)