Handle module failures gracefully while gathering telemetry. (#125)

Handle module failures gracefully while gathering telemetry.

Author: Robert Jackson

lib/gather-telemetry.js

@@ -9,18 +9,29 @@ module.exports = async function gatherTelemetry(url) {
 
   // Get the "viewport" of the page, as reported by the page.
   const telemetry = await page.evaluate(() => {
+    const SKIPPED_MODULES = ["fetch/ajax"];
+
     /* globals window, Ember */
     let telemetry = {};
 
     const modules = Object.keys(window.require.entries);
 
     for (let modulePath of modules) {
-      let module = require(modulePath);
+      if (SKIPPED_MODULES.includes(modulePath)) {
+        continue;
+      }
 
-      if (module && module.default && module.default.proto) {
-        let defaultProto = module.default.proto();
+      try {
+        let module = require(modulePath);
 
-        telemetry[modulePath] = parseMeta(Ember.meta(defaultProto));
+        if (module && module.default && module.default.proto) {
+          let defaultProto = module.default.proto();
+
+          telemetry[modulePath] = parseMeta(Ember.meta(defaultProto));
+        }
+      } catch (error) {
+        // log the error, but continue
+        console.error(`error evaluating \`${modulePath}\`: ${error.message}`); // eslint-disable-line no-console
       }
     }
 

test/fixtures/input/app/utils/module-with-error.js

@@ -0,0 +1 @@
+throw new Error('This should not fail the telemetry gathering!');

test/fixtures/output/app/utils/module-with-error.js

@@ -0,0 +1 @@
+throw new Error('This should not fail the telemetry gathering!');