Merge pull request #20 from flecno/acl

Add support for ACL on objects

Author: ghedamat

.jshintrc

@@ -5,6 +5,7 @@
     "-Promise"
   ],
   "browser": true,
+  "node": true,
   "boss": true,
   "curly": true,
   "debug": false,

README.md

@@ -83,6 +83,12 @@ The region the AWS `bucket` is located in.
 
 *Default:* `undefined`
 
+### acl
+
+The ACL to apply to the objects.
+
+*Default:* `public-read`
+
 ### prefix
 
 A directory within the `bucket` that the files should be uploaded in to.

index.js

@@ -15,6 +15,7 @@ module.exports = {
       defaultConfig: {
         filePattern: '**/*.{js,css,png,gif,ico,jpg,map,xml,txt,svg,swf,eot,ttf,woff,woff2}',
         prefix: '',
+        acl: 'public-read',
         distDir: function(context) {
           return context.distDir;
         },
@@ -44,6 +45,7 @@ module.exports = {
         var distFiles     = this.readConfig('distFiles');
         var gzippedFiles  = this.readConfig('gzippedFiles');
         var bucket        = this.readConfig('bucket');
+        var acl           = this.readConfig('acl');
         var prefix        = this.readConfig('prefix');
         var manifestPath  = this.readConfig('manifestPath');
 
@@ -59,6 +61,7 @@ module.exports = {
           gzippedFilePaths: gzippedFiles,
           prefix: prefix,
           bucket: bucket,
+          acl: acl,
           manifestPath: manifestPath
         };
 

lib/s3.js

@@ -65,7 +65,7 @@ module.exports = CoreObject.extend({
     var cwd              = options.cwd;
     var bucket           = options.bucket;
     var prefix           = options.prefix;
-    var acl              = options.acl || 'public-read';
+    var acl              = options.acl;
     var gzippedFilePaths = options.gzippedFilePaths || [];
     var cacheControl     = 'max-age='+TWO_YEAR_CACHE_PERIOD_IN_SEC+', public';
     var expires          = EXPIRE_IN_2030;

tests/.jshintrc

@@ -23,8 +23,9 @@
     "currentPath",
     "currentRouteName"
   ],
-  "node": false,
+  "node": true,
   "browser": false,
+  "mocha": true,
   "boss": true,
   "curly": false,
   "debug": false,

tests/unit/index-nodetest.js

@@ -38,6 +38,7 @@ describe('s3 plugin', function() {
           bucket: 'cccc',
           region: 'dddd',
           filePattern: '*.{css,js}',
+          acl: 'authenticated-read',
           prefix: '',
           distDir: function(context) {
             return context.distDir;

tests/unit/lib/s3-nodetest.js

@@ -96,6 +96,7 @@ describe('s3', function() {
           filePaths: ['app.css'],
           cwd: process.cwd() + '/tests/fixtures/dist',
           prefix: 'js-app',
+          acl: 'public-read',
           bucket: 'some-bucket'
         };