Add tests for deploy without activation message, and activation message

Author: jkeen

index.js

@@ -112,7 +112,9 @@ module.exports = {
         this.log('preparing to activate `' + revisionKey + '`', { verbose: true });
 
         var s3 = new this.S3({ plugin: this });
-        return s3.activate(options).then(function() {
+        return s3.activate(options).then(() => {
+          this.log(`✔ Activated revision \`${revisionKey}\``, {});
+
           return {
             revisionData: {
               activatedRevisionKey: revisionKey

tests/unit/index-test.js

@@ -61,6 +61,7 @@ describe('s3-index plugin', function() {
     });
 
     context = {
+      deployTarget: "qa",
       ui: mockUi,
 
       project: stubProject,
@@ -262,6 +263,15 @@ describe('s3-index plugin', function() {
             assert.equal(Object.prototype.hasOwnProperty.call(s3Options, 'serverSideEncryption'), false, 'serverSideEncryption filtered correctly');
           });
       });
+
+      it('displays activation message when revision is activated', function() {
+        var promise = plugin.activate(context);
+
+        return assert.isFulfilled(promise)
+          .then(function() {
+            assert.match(mockUi.messages.join("\n"),  new RegExp(`✔ Activated revision \`${REVISION_KEY}\``));
+          });
+      })
     });
 
     describe('#fetchInitialRevisions', function() {
@@ -315,5 +325,21 @@ describe('s3-index plugin', function() {
           });
       });
     });
+
+    describe('#didDeploy', function() {
+      it("prints default message about lack of activation when revision has not been activated", function() {
+        plugin.upload = function() {};
+        plugin.activate = function() {};
+        plugin.beforeHook(context);
+        plugin.configure(context);
+        plugin.beforeHook(context);
+        plugin.didDeploy(context);
+
+        let message = mockUi.messages.join("\n")
+        assert.match(message, new RegExp(`Deployed but did not activate revision ${REVISION_KEY}`));
+        assert.match(message, /To activate, run/);
+        assert.match(message, new RegExp(`ember deploy:activate qa --revision=${REVISION_KEY}`));
+      });
+    });
   });
 });