Skip to content

Commit f53a982

Browse files
committed
Implement the prepare hook instead of didBuild
1 parent 280bf35 commit f53a982

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ ember install ember-cli-deploy-revision-data
4444
For detailed information on what plugin hooks are and how they work, please refer to the [Plugin Documentation][1].
4545

4646
- `configure`
47-
- `didBuild`
47+
- `prepare`
4848

4949
## Configuration Options
5050

@@ -152,4 +152,4 @@ The following properties are expected to be present on the deployment `context`
152152

153153
[1]: http://ember-cli.github.io/ember-cli-deploy/plugins "Plugin Documentation"
154154
[2]: https://github.com/zapnito/ember-cli-deploy-build "ember-cli-deploy-build"
155-
[3]: https://github.com/ember-cli/ember-cli-deploy "ember-cli-deploy"
155+
[3]: https://github.com/ember-cli/ember-cli-deploy "ember-cli-deploy"

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ module.exports = {
2222
},
2323
versionFile: 'package.json',
2424
},
25-
didBuild: function(context) {
25+
prepare: function(context) {
2626
var self = this;
2727
var type = this.readConfig('type');
2828
var DataGenerator = require('./lib/data-generators')[type];

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
"rsvp": "^3.0.18"
5454
},
5555
"ember-addon": {
56-
"configPath": "tests/dummy/config",
57-
"after": "ember-cli-deploy-json-config"
56+
"configPath": "tests/dummy/config"
5857
}
5958
}

tests/unit/index-nodetest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('the index', function() {
3030
});
3131

3232
assert.typeOf(plugin.configure, 'function');
33-
assert.typeOf(plugin.didBuild, 'function');
33+
assert.typeOf(plugin.prepare, 'function');
3434
});
3535

3636
describe('configure hook', function() {
@@ -101,7 +101,7 @@ describe('the index', function() {
101101
});
102102
});
103103

104-
describe('didBuild hook', function() {
104+
describe('prepare hook', function() {
105105
it('returns the revisionData', function() {
106106
var plugin = subject.createDeployPlugin({
107107
name: 'revision-data'
@@ -126,7 +126,7 @@ describe('the index', function() {
126126
};
127127
plugin.beforeHook(context);
128128

129-
return assert.isFulfilled(plugin.didBuild(context))
129+
return assert.isFulfilled(plugin.prepare(context))
130130
.then(function(result) {
131131
assert.equal(result.revisionData.revisionKey, 'ae1569f72495012cd5e8588e0f2f5d49');
132132
assert.isNotNull(result.revisionData.timestamp);

0 commit comments

Comments
 (0)