Skip to content

Commit d280117

Browse files
committed
Embrace being a node-only ember-cli addon
- use eslint directly - remove lots of dependencies required only for building browser code - remove lots of boilerplate ember-cli addon files and directories
1 parent faa7bba commit d280117

39 files changed

+46
-652
lines changed

.bowerrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

.travis.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,19 @@
11
---
22
language: node_js
33
node_js:
4-
- "4"
4+
- "6"
55

66
sudo: false
77

88
cache:
99
yarn: true
1010

11+
before_install:
12+
- curl -o- -L https://yarnpkg.com/install.sh | bash
13+
- export PATH=$HOME/.yarn/bin:$PATH
14+
15+
install:
16+
- yarn install --no-lockfile
17+
1118
script:
1219
- yarn test

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,8 @@ Omitted keys are not displayed in listing the results.
6464

6565
## Tests
6666

67-
* ember test
67+
* yarn test
68+
69+
## Why `ember build` and `ember test` don't work
70+
71+
Since this is a node-only ember-cli addon, this package does not include many files and dependencies which are part of ember-cli's typical `ember build` and `ember test` processes.

addon/.gitkeep

Whitespace-only changes.

app/.gitkeep

Whitespace-only changes.

ember-cli-build.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* jshint node: true */
1+
/*eslint-env node*/
22
'use strict';
33

44
var DeployPluginBase = require('ember-cli-deploy-plugin');
@@ -22,7 +22,7 @@ module.exports = {
2222
}
2323
},
2424

25-
displayRevisions: function(context) {
25+
displayRevisions: function(/* context */) {
2626
var table;
2727
var revisions = this.readConfig('revisions');
2828
if(!revisions || revisions.length === 0) {
@@ -41,7 +41,7 @@ module.exports = {
4141
} else {
4242
table = new LegacyTable(this, revisions);
4343
}
44-
44+
4545
table.display();
4646
}
4747
});

lib/legacy-table.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/*eslint-env node*/
12
var moment = require('moment');
23
var CoreObject = require('core-object');
34

lib/scm-table.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* jshint node: true */
1+
/*eslint-env node*/
22
var Table = require('cli-table2');
33
var moment = require('moment');
44
var CoreObject = require('core-object');
@@ -12,7 +12,7 @@ module.exports = CoreObject.extend({
1212
this.revisions = revisions;
1313
},
1414

15-
display: function(revisions) {
15+
display: function(/* revisions */) {
1616
var table = this._createTable();
1717
this._tableRows(table);
1818

package.json

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,53 +12,28 @@
1212
"doc": "doc",
1313
"test": "tests"
1414
},
15-
"repository": "https://github.com/duizendnegen/ember-cli-deploy-display-revisions",
15+
"repository": "https://github.com/ember-cli-deploy/ember-cli-deploy-display-revisions",
1616
"scripts": {
17-
"build": "ember build",
18-
"start": "ember server",
19-
"test": "node tests/runner.js"
17+
"test": "node tests/runner.js && ./node_modules/.bin/eslint index.js lib/* tests/*"
2018
},
2119
"dependencies": {
2220
"cli-table2": "^0.2.0",
2321
"core-object": "^2.0.0",
24-
"ember-cli-babel": "^5.1.7",
2522
"ember-cli-deploy-plugin": "^0.2.3",
2623
"moment": "^2.18.0",
2724
"rsvp": "^3.5.0"
2825
},
2926
"devDependencies": {
30-
"broccoli-asset-rev": "^2.4.5",
3127
"chai": "^3.5.0",
3228
"chai-as-promised": "^6.0.0",
33-
"ember-ajax": "^2.4.1",
3429
"ember-cli": "^2.12.0",
35-
"ember-cli-app-version": "^2.0.0",
36-
"ember-cli-dependency-checker": "^1.3.0",
37-
"ember-cli-eslint": "^3.0.2",
38-
"ember-cli-htmlbars": "^1.1.1",
39-
"ember-cli-htmlbars-inline-precompile": "^0.3.6",
40-
"ember-cli-inject-live-reload": "^1.4.1",
41-
"ember-cli-qunit": "^3.0.1",
4230
"ember-cli-release": "^1.0.0-beta.2",
43-
"ember-cli-shims": "^1.0.2",
44-
"ember-cli-sri": "^2.1.0",
45-
"ember-cli-test-loader": "^1.1.0",
46-
"ember-cli-uglify": "^1.2.0",
47-
"ember-data": "^2.11.0",
48-
"ember-disable-prototype-extensions": "^1.1.0",
49-
"ember-export-application-global": "^1.0.5",
50-
"ember-load-initializers": "^0.6.0",
51-
"ember-resolver": "^3.0.0",
52-
"ember-source": "^2.12.0",
53-
"eslint-plugin-mocha": "^4.9.0",
31+
"eslint": "^3.18.0",
5432
"glob": "^7.1.1",
55-
"loader.js": "^4.0.10",
5633
"mocha": "^3.2.0"
5734
},
5835
"engines": {
59-
"node": ">= 0.12.0"
36+
"node": ">= 4"
6037
},
61-
"ember-addon": {
62-
"configPath": "tests/dummy/config"
63-
}
38+
"ember-addon": {}
6439
}

0 commit comments

Comments
 (0)