Make sure we handle # in links (#3999)

- see #3995

Author: yyoncho

lsp-mode.el

@@ -1774,7 +1774,12 @@ On other systems, returns path without change."
          (file
           (concat (decode-coding-string (url-filename url)
                                         (or locale-coding-system 'utf-8))
-                  (when target
+                  (when (and target
+                             (not (s-match
+                                   (rx "#" (group (1+ num)) (or "," "#")
+                                       (group (1+ num))
+                                       string-end)
+                                   uri)))
                     (concat "#" target))))
          (file-name (if (and type (not (string= type "file")))
                         (if-let ((handler (lsp--get-uri-handler type)))
@@ -4869,7 +4874,7 @@ Applies on type formatting."
     (pcase type
       ("file"
        (find-file (lsp--uri-to-path url))
-       (-when-let ((_ line column) (s-match (rx "#" (group (1+ num)) "," (group (1+ num))) url))
+       (-when-let ((_ line column) (s-match (rx "#" (group (1+ num)) (or "," "#") (group (1+ num))) url))
          (goto-char (lsp--position-to-point
                      (lsp-make-position :character (1- (string-to-number column))
                                         :line (1- (string-to-number line)))))))

test/lsp-common-test.el

@@ -27,13 +27,15 @@
 
 (ert-deftest lsp--path-to-uri-1 ()
   (elenv-with-windows
-    (let ((lsp--uri-file-prefix "file:///"))
-      (should (equal (lsp--path-to-uri "c:/Users/?/") "file:///c:/Users/%3F/"))))
+   (let ((lsp--uri-file-prefix "file:///"))
+     (should (equal (lsp--path-to-uri "c:/Users/?/") "file:///c:/Users/%3F/"))))
   (elenv-with-os '(darwin gnu/linux)
-    (let ((lsp--uri-file-prefix "file://"))
-      (should (equal (lsp--path-to-uri "/root/file/hallo welt") "file:///root/file/hallo%20welt")))
-    (should (equal (lsp--uri-to-path "file:///home/nim-%23devel")
-                   "/home/nim-#devel"))))
+                 (let ((lsp--uri-file-prefix "file://"))
+                   (should (equal (lsp--path-to-uri "/root/file/hallo welt") "file:///root/file/hallo%20welt")))
+                 (should (equal (lsp--uri-to-path "file:///home/nim-%23devel")
+                                "/home/nim-#devel"))
+                 (should (equal (lsp--uri-to-path "file:///home/yyoncho/Sources/DemoProjects/lua/lua.lua#1#9")
+                                "/home/yyoncho/Sources/DemoProjects/lua/lua.lua"))))
 
 (ert-deftest lsp--path-to-uri-2 ()
   (let ((lsp--uri-file-prefix "file:///")