Fix up many linting issues (#4652)

* use clangd-15 instead of clangd-11 in CI

* Fix up types for customize

* fix quote escaping

* Fix equality check

eq does object identity checking, while equal does recursive value checking.

* make sure to pass the TCP port

* lsp-camel-jar-file is a file

---------

Co-authored-by: Jen-Chieh Shen <jcs090218@gmail.com>

Author: rtpg

clients/lsp-autotools.el

@@ -41,7 +41,7 @@
      makefile-bsdmake-mode
      makefile-imake-mode)
   "List of major mode that work with Autotools."
-  :type '(list symbol)
+  :type '(repeat function)
   :group 'lsp-autotools)
 
 (defun lsp-autotools--download-server (_client callback error-callback update?)

clients/lsp-awk.el

@@ -36,7 +36,7 @@
   "Command to run the AWK language server."
   :group 'lsp-awk
   :risky t
-  :type '(list string))
+  :type '(repeat string))
 
 (lsp-register-client
  (make-lsp-client

clients/lsp-clojure.el

@@ -94,7 +94,7 @@
                                           (expand-file-name "~/.gitlibs/libs"))
   "LSP clojure dirs that should be considered library folders."
   :group 'lsp-clojure
-  :type '(list string))
+  :type '(repeat directory))
 
 (defcustom lsp-clojure-test-tree-position-params nil
   "The optional test tree position params.

clients/lsp-cucumber.el

@@ -41,7 +41,7 @@ This is only for development use."
 (defcustom lsp-cucumber-active-modes
   '( feature-mode)
   "List of major mode that work with Cucumber language server."
-  :type '(list symbol)
+  :type '(repeat function)
   :group 'lsp-cucumber)
 
 (lsp-defcustom lsp-cucumber-features

clients/lsp-eslint.el

@@ -176,7 +176,7 @@ workspace (see https://eslint.org/docs/user-guide/command-line-interface)."
 
 (defcustom lsp-eslint-code-action-disable-rule-comment t
   "Controls whether code actions to add a rule-disabling comment should be shown."
-  :type 'bool
+  :type 'boolean
   :package-version '(lsp-mode . "6.3"))
 
 (defcustom lsp-eslint-code-action-disable-rule-comment-location "separateLine"
@@ -193,12 +193,12 @@ Accepts the following values:
 (defcustom lsp-eslint-code-action-show-documentation t
   "Controls whether code actions to show documentation for an ESLint rule should
 be shown."
-  :type 'bool
+  :type 'boolean
   :package-version '(lsp-mode . "8.0.0"))
 
 (defcustom lsp-eslint-warn-on-ignored-files nil
   "Controls whether a warning should be emitted when a file is ignored."
-  :type 'bool
+  :type 'boolean
   :package-version '(lsp-mode . "8.0.0"))
 
 (defcustom lsp-eslint-rules-customizations []

clients/lsp-glsl.el

@@ -36,7 +36,7 @@
   "Command to run the GLSL language server."
   :group 'lsp-glsl
   :risky t
-  :type '(list string))
+  :type '(repeat string))
 
 (lsp-register-client
  (make-lsp-client

clients/lsp-idris.el

@@ -45,7 +45,9 @@
 (defcustom lsp-idris2-lsp-trace-server "off"
   "Traces the communication between VS Code and the language server."
   :group 'lsp-idris
-  :type '(choice (:tag "off" "messages" "verbose"))
+  :type '(choice (const "off")
+                 (const "messages")
+                 (const "verbose"))
   :package-version '(lsp-mode . "9.0.0"))
 
 (lsp-register-custom-settings

clients/lsp-kotlin.el

@@ -50,7 +50,10 @@ executable with `exec-path'."
 
 (defcustom lsp-kotlin-trace-server "off"
   "Traces the communication between VSCode and the Kotlin language server."
-  :type '(choice (:tag "off" "messages" "verbose"))
+  :type '(choice (const "off")
+                 (const "messages")
+                 (const "verbose")
+         )
   :group 'lsp-kotlin
   :package-version '(lsp-mode . "6.1"))
 

clients/lsp-lisp.el

@@ -34,7 +34,7 @@
 (defcustom lsp-lisp-active-modes
   '( lisp-mode)
   "List of major mode that work with lisp."
-  :type '(list symbol)
+  :type '(repeat function)
   :group 'lsp-lisp)
 
 (defcustom lsp-lisp-alive-port 8006

clients/lsp-lua.el

@@ -137,13 +137,18 @@
 
 (defcustom lsp-lua-color-mode "Semantic"
   "Color mode."
-  :type '(choice (:tag "Grammar" "Semantic"))
+  :type '(choice (const "Grammar")
+                 (const "Semantic"))
   :package-version '(lsp-mode . "8.0.0")
   :group 'lsp-lua-language-server)
 
 (defcustom lsp-lua-completion-call-snippet "Disable"
   "Shows function call snippets."
-  :type '(choice (:tag "Disable" "Both" "Replace"))
+  :type '(choice
+          (const "Disable")
+          (const "Both")
+          (const "Replace")
+          )
   :package-version '(lsp-mode . "8.0.0")
   :group 'lsp-lua-language-server)
 
@@ -165,7 +170,9 @@ fragment.  If it is set to `0`, this feature can be disabled."
 
 (defcustom lsp-lua-completion-keyword-snippet "Replace"
   "Shows keyword syntax snippets."
-  :type '(choice (:tag "Disable" "Both" "Replace"))
+  :type '(choice (const "Disable")
+                 (const "Both")
+                 (const "Replace"))
   :package-version '(lsp-mode . "8.0.0")
   :group 'lsp-lua-language-server)
 
@@ -339,7 +346,8 @@ tolerance for this setting. Please adjust it to the appropriate value."
 (defcustom lsp-lua-runtime-file-encoding "utf8"
   "File encoding.  The `ansi' option is only available under the `Windows'
 platform."
-  :type '(choice (:tag "utf8" "ansi"))
+  :type '(choice (const "utf8")
+                 (const "ansi"))
   :package-version '(lsp-mode . "8.0.0")
   :group 'lsp-lua-language-server)
 
@@ -383,7 +391,13 @@ and the language server will provide special support.
 
 (defcustom lsp-lua-runtime-version "Lua 5.4"
   "Lua runtime version."
-  :type '(choice (:tag "Lua 5.1" "Lua 5.2" "Lua 5.3" "Lua 5.4" "LuaJIT"))
+  :type '(choice
+                  (const "Lua 5.1")
+                  (const "Lua 5.2")
+                  (const "Lua 5.3")
+                  (const "Lua 5.4")
+                  (const "LuaJIT")
+                  )
   :package-version '(lsp-mode . "8.0.0")
   :group 'lsp-lua-language-server)